From owner-freebsd-current Fri Sep 22 12:56:25 2000 Delivered-To: freebsd-current@freebsd.org Received: from roaming.cacheboy.net (roaming.cacheboy.net [203.56.168.69]) by hub.freebsd.org (Postfix) with ESMTP id 02F5C37B424; Fri, 22 Sep 2000 12:56:17 -0700 (PDT) Received: (from adrian@localhost) by roaming.cacheboy.net (8.11.0/8.11.0) id e8MJtu600558; Fri, 22 Sep 2000 21:55:56 +0200 (CEST) (envelope-from adrian) Date: Fri, 22 Sep 2000 21:55:55 +0200 From: Adrian Chadd To: Bruce Evans Cc: freebsd-fs@FreeBSD.ORG, freebsd-current@FreeBSD.ORG Subject: Re: Fsck wrappers, revisited Message-ID: <20000922215555.A449@roaming.cacheboy.net> References: <20001223112038.A37548@roaming.cacheboy.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.4i In-Reply-To: ; from bde@zeta.org.au on Sat, Sep 23, 2000 at 03:00:11AM +1100 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, Sep 23, 2000, Bruce Evans wrote: > On Sat, 23 Dec 2000, Adrian Chadd wrote: > > > Here's the patch: > > > > --- fsck.c.orig Sat Dec 23 11:13:30 2000 > > +++ fsck.c Sat Dec 23 11:13:34 2000 > > @@ -501,7 +501,7 @@ > > errx(1, "partition `%s' is not of a legal vfstype", > > str); > > - if ((vfstype = dktypenames[t]) == NULL) > > + if ((vfstype = fstypenames[t]) == NULL) > > errx(1, "vfstype `%s' on partition `%s' is not supported", > > fstypenames[t], str); > > > > > > So now is a problem which I'm sure the NetBSD people came up against. > > The fstypenames are names like 4.2BSD, vinum, ISO9660, etc. NetBSD fixed > > this by creating a new list 'mountnames[]', which maps the fs type to > > a string. > > fs typenames are already strings in FreeBSD (the kernel's vfc_index is an > implementation detail which should not be visible in applications). > > > http://cvsweb.netbsd.org/bsdweb.cgi/syssrc/sys/sys/disklabel.h.diff?r1=1.60&r2=1.61 > > > > What do people think about doing this as well? It would certainly make things > > a little tidier, but every time a new fs comes in the magic autodetection code > > will need to be updated (if appropriate, of course.) > > This would be a bug. So what would your suggestion here be? This is only used if a -t isn't given or you don't have an entry in /etc/fstab, so I personally don't think its a big issue. Adrian -- Adrian Chadd "The main reason Santa is so jolly is because he knows where all the bad girls live." -- Random IRC quote To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message