From owner-svn-src-head@FreeBSD.ORG Tue Jun 9 18:06:14 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 47590448; Tue, 9 Jun 2015 18:06:14 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (unknown [IPv6:2001:7b8:3a7:0:20e:cff:fea0:e4a2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 74EB31547; Tue, 9 Jun 2015 18:06:13 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:7b8:3a7::e55a:cb77:5eab:3bb0] (unknown [IPv6:2001:7b8:3a7:0:e55a:cb77:5eab:3bb0]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 664552115A; Tue, 9 Jun 2015 20:06:07 +0200 (CEST) Subject: Re: svn commit: r284167 - head/sys/i386/i386 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Content-Type: multipart/signed; boundary="Apple-Mail=_F0EFAA0E-FAE0-4F0D-A1A6-109D8BF54FD9"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.5 From: Dimitry Andric In-Reply-To: <20150609162836.C935@besplex.bde.org> Date: Tue, 9 Jun 2015 20:05:55 +0200 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <14AE3E08-5D5D-437F-A2D3-C89A8CF4B0C1@FreeBSD.org> References: <201506082012.t58KCjZX023061@svn.freebsd.org> <20150609162836.C935@besplex.bde.org> To: Bruce Evans X-Mailer: Apple Mail (2.2098) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2015 18:06:14 -0000 --Apple-Mail=_F0EFAA0E-FAE0-4F0D-A1A6-109D8BF54FD9 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 09 Jun 2015, at 08:44, Bruce Evans wrote: > > On Mon, 8 Jun 2015, Dimitry Andric wrote: > >> Log: >> Merge r283870 from amd64: >> >> Remove unneeded NULL checks in trap_fatal(). >> >> Since td_name is an array member of struct thread, it can never be NULL, >> so the check can be removed. In addition, curproc can never be NULL, >> so remove the if statement, and splice the two printfs() together. >> >> While here, remove the u_long cast, and use the correct printf format >> specifier for curproc->p_pid. >> >> Requested by: jhb > > Er. I gave a longer review which implicity requested not doing all of > this. The format was correct (it matched the cast), and the cast was > less wrong than not casting. Please read https://reviews.freebsd.org/D2695, where Kostik argued "pid_t is int32_t on all arches", and I agreed with that. The previous obfuscation is unnecessary now. > Both amd64/trap.c i386/trap.c still print pids portably (by casting > to long) in one place. They each had 2 unportable printings of pids; > now they each have 3 unportable printings of pids. I wasn't updating the other parts of the code, so I stayed out of there for now. Feel free to put a review in Phabricator to make everything consistent. -Dimitry --Apple-Mail=_F0EFAA0E-FAE0-4F0D-A1A6-109D8BF54FD9 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.27 iEYEARECAAYFAlV3Kw4ACgkQsF6jCi4glqN3yQCgvk6xfYmX+RtDRGUePIorZfBO xWAAoMUJsnZoVcztyLSBW2bnaeyOgvA4 =XhHI -----END PGP SIGNATURE----- --Apple-Mail=_F0EFAA0E-FAE0-4F0D-A1A6-109D8BF54FD9--