Date: Mon, 26 Jun 2017 13:16:19 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r443975 - in head: games/aquaria multimedia/libmediainfo sysutils/fusefs-encfs textproc/tinyxml2 Message-ID: <r2y7-ngn0-wny@FreeBSD.org> In-Reply-To: <a851-fe36-wny@FreeBSD.org> (Jan Beich's message of "Wed, 21 Jun 2017 19:25:01 %2B0200") References: <201706201359.v5KDx8GL059406@repo.freebsd.org> <a851-fe36-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Jan Beich <jbeich@FreeBSD.org> writes: > Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> writes: > >> Author: sunpoet >> Date: Tue Jun 20 13:59:08 2017 >> New Revision: 443975 >> URL: https://svnweb.freebsd.org/changeset/ports/443975 >> >> Log: >> Update textproc/tinyxml2 to 5.0.0 >> >> - Use PLIST instead of PLIST_FILES >> - Bump PORTREVISION for shlib change >> >> Changes: https://github.com/leethomason/tinyxml2/commits/master >> >> Added: >> head/textproc/tinyxml2/pkg-plist (contents, props changed) >> Modified: >> head/games/aquaria/Makefile >> head/multimedia/libmediainfo/Makefile >> head/sysutils/fusefs-encfs/Makefile >> head/textproc/tinyxml2/Makefile >> head/textproc/tinyxml2/distinfo > > At least games/aquaria is now broken: > > CMakeFiles/aquaria.dir/Aquaria/Continuity.cpp.o: In function > `Continuity::loadFileData(int, tinyxml2::XMLDocument&)': > /wrkdirs/usr/ports/games/aquaria/work/Aquaria-OSE-v1.002-22-g84366ad/Aquaria/Continuity.cpp:(.text+0x156ef): > undefined reference to `tinyxml2::StrPair::GetStr()' > CMakeFiles/aquaria.dir/Aquaria/DSQ.cpp.o: In function > `DSQ::loadModsCallback(std::__1::basic_string<char, > std::__1::char_traits<char>, std::__1::allocator<char> > const&, > int)': > /wrkdirs/usr/ports/games/aquaria/work/Aquaria-OSE-v1.002-22-g84366ad/Aquaria/DSQ.cpp:(.text+0xe01d): > undefined reference to `tinyxml2::StrPair::GetStr()' > c++: error: linker command failed with exit code 1 (use -v to see invocation) > *** Error code 1 > > https://lists.freebsd.org/pipermail/freebsd-pkg-fallout/Week-of-Mon-20170619/490103.html I've fixed this. Next time, please, properly test consumers, not just blindly bump PORTREVISION. AquariaOSE upstream believes the regression is in TinyXML2. Some symbols (e.g., StrPair::GetStr) disappeared in 5.0.0 despite *still* being part of the public API. XMLDocument::GetErrorStr1() is no longer usable which also broke other consumers (not in ports). https://github.com/leethomason/tinyxml2/issues/498 https://github.com/KAPSARC/KTAB/commit/120dba9fb7a7
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?r2y7-ngn0-wny>