Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 29 Aug 2006 19:01:47 +0300
From:      Giorgos Keramidas <keramida@freebsd.org>
To:        Remko Lodder <remko@freebsd.org>
Cc:        doc-committers@freebsd.org, cvs-doc@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: CVSROOT commitcheck
Message-ID:  <20060829160147.GB61380@gothmog.pc>
In-Reply-To: <200608282020.k7SKKded076011@repoman.freebsd.org>
References:  <200608282020.k7SKKded076011@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2006-08-28 20:20, Remko Lodder <remko@freebsd.org> wrote:
> remko       2006-08-28 20:20:39 UTC
> 
>   FreeBSD doc repository
> 
>   Modified files:
>     .                    commitcheck 
>   Log:
>   Avoid warning when cvs has only three numbers in its version string.
>   
>   Obtained from:  src commitcheck fix
>   Approved by:    simon (cvsadm)
>   
>   Revision  Changes    Path
>   1.28      +1 -0      CVSROOT/commitcheck

GO Remko!!!

I've used a similar change in a local CVSROOT/ copy for ages (at least
until Oct 2004, AFAICT from the logs here), but I don't remember if I
mailed cvsmeisters about it or if it was ever approved:

% $ cvs rdiff -u -r1.2 CVSROOT/commitcheck
% Index: CVSROOT/commitcheck
% diff -u CVSROOT/commitcheck:1.2 CVSROOT/commitcheck:1.8
% --- CVSROOT/commitcheck:1.2     Wed Jul  7 15:40:43 2004
% +++ CVSROOT/commitcheck Tue Oct  5 13:37:14 2004
% @@ -1,7 +1,10 @@
%  #!/usr/bin/perl -w
%  #
% -# $Id: commitcheck,v 1.2 2004/07/07 12:40:43 gkeramidas Exp $
% +# $Id: commitcheck,v 1.8 2004/10/05 10:37:14 gkeramidas Exp $
%  #
% +# Original version:
% +# $FreeBSD: CVSROOT-src/commitcheck,v 1.27 2004/09/01 03:12:06 kuriyama Exp $
% +
%  # This script is the first thing that is run at commit time
%  # to determine whether the committer has commit priviledges.
%  # (See CVSROOT/commitinfo).
% @@ -43,7 +42,9 @@
%  my $VERSTR = `$cfg::PROG_CVS -v`;
%  $VERSTR =~ s/.*Concurrent\D*(\S*).*/$1/s;
%  $VERSTR =~ s/\D+/./g;
% -my $VERSION = sprintf "%d%02d%02d%02d\n", split /\./, $VERSTR;
% +$VERSTR =~ s/\.$/.0/;
% +$VERSTR =~ s/$/.0.0.0.0/;
% +my $VERSION = sprintf "%d%02d%02d%02d\n", (split /\./, $VERSTR)[0,1,2,3];
%  unless ($VERSION && $VERSION >= $cfg::MINCVSVERSION) {
%         print "The wrong version of CVS is installed (commitcheck)!\n";
%         exit 1;

Thank you for fixing this to our FreeBSD repo scripts too :-)




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060829160147.GB61380>