From owner-freebsd-security@FreeBSD.ORG Tue Oct 2 22:00:59 2012 Return-Path: Delivered-To: freebsd-security@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 92DF2106566B for ; Tue, 2 Oct 2012 22:00:59 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 571768FC16 for ; Tue, 2 Oct 2012 22:00:58 +0000 (UTC) Received: by pbbrp8 with SMTP id rp8so10631615pbb.13 for ; Tue, 02 Oct 2012 15:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=GLjOWKPJZYsTSNVLikkt2y4cXpyKj5/Ydlw1SXMNivU=; b=V87kTcSoPZf2mK2+rox9rpx1NKMUENm5R7EdqVnuUH39M+wr2fz3wtjTz4ZSRwzc79 loQPXpTHv0ahmLgf2GWBoAVzRo8pWfKRGalGBsKxdRHOSVeiMShd/NqPesSJpR3+jW0P SokC/tbCyU9xk0TYn9MrTd9QBZVxkmc/qtfbY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-gm-message-state; bh=GLjOWKPJZYsTSNVLikkt2y4cXpyKj5/Ydlw1SXMNivU=; b=jehL+aARcAe+ERlUx1drmtmEhf80z6lMicKQh7iPUh6Gm52lp5ROHoovd9C13MTsus 0sQ1Qav3SLBPVq7W2pPBDnhmv681z1CYIWXLb0OoAWYJHbD12bK6YM819JrhikmReuL0 1EkJAURltuI+zhPjNnnBtvPub+5TstYlAFB3fJO3utptKZg9TokXmqDF7E9DwqxF8VZu rAhgeKLNHwBTt9nl08SnimvybyLoLLGpC2iyatrRNC9CrcRB10glvnpz3I7XexfkE1Sb L9helRpus3QlhYeWe4XSWzM3dFP82CAqRHBO7oYtfMqo6UaSFjr30W1ZYNJYTARmmPQ5 xq3g== Received: by 10.68.242.231 with SMTP id wt7mr7667517pbc.99.1349215258735; Tue, 02 Oct 2012 15:00:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.66.190.164 with HTTP; Tue, 2 Oct 2012 15:00:28 -0700 (PDT) In-Reply-To: <87FA4CBA-001F-4C92-8B92-D650A9678864@cederstrand.dk> References: <9DD86238-51C8-4F38-B7EB-BD773039888B@cederstrand.dk> <20121001104901.GJ35915@deviant.kiev.zoral.com.ua> <20121001110805.GL35915@deviant.kiev.zoral.com.ua> <506B6024.8050908@delphij.net> <87FA4CBA-001F-4C92-8B92-D650A9678864@cederstrand.dk> From: Eitan Adler Date: Tue, 2 Oct 2012 18:00:28 -0400 Message-ID: To: Erik Cederstrand Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQlM8cxcQFkmnNYr0onJyKLEudDbh9q/zDEuoAFTa8GKu2KMtr9gSlbKYiUYc8ydlR6Ey1PD Cc: Konstantin Belousov , "freebsd-security@freebsd.org" , d@delphij.net Subject: Re: Opinion on checking return value of setuid(getuid())? X-BeenThere: freebsd-security@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Security issues \[members-only posting\]" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2012 22:00:59 -0000 On 2 October 2012 17:56, Erik Cederstrand wrote: >> It doesn't seem hurt in general but if you are going to commit it >> please also change the other instances in the base system. I shall do so. I will probably do them in spurts > I'll do my best. There are around 200 of these in base, but some are the result of macro expansion so it may not be too bad. Please cc me on the PRs you send. I will take them all and commit them in bunches. Thanks! -- Eitan Adler