Date: Tue, 2 Oct 2012 18:00:28 -0400 From: Eitan Adler <lists@eitanadler.com> To: Erik Cederstrand <erik@cederstrand.dk> Cc: Konstantin Belousov <kostikbel@gmail.com>, "freebsd-security@freebsd.org" <freebsd-security@freebsd.org>, d@delphij.net Subject: Re: Opinion on checking return value of setuid(getuid())? Message-ID: <CAF6rxg=vyDgXfV-JM6su5BZ8QZvpBsn04_Qcig5BLoVxoyy7bA@mail.gmail.com> In-Reply-To: <87FA4CBA-001F-4C92-8B92-D650A9678864@cederstrand.dk> References: <9DD86238-51C8-4F38-B7EB-BD773039888B@cederstrand.dk> <20121001104901.GJ35915@deviant.kiev.zoral.com.ua> <F81C009D-F993-4398-B377-D0B4A0ABA7E3@cederstrand.dk> <20121001110805.GL35915@deviant.kiev.zoral.com.ua> <CAF6rxgmKWfefr5tvM3-0PQM3EKWockkb8A4sCiyYekxs5b4fGA@mail.gmail.com> <ECC8690A-9B5D-41FB-BF1D-CC170147BEEC@cederstrand.dk> <CAF6rxgnkLcoL4eAbKxC=-OY=G9O--TLYT8C2xEtu1u7yrNUD5A@mail.gmail.com> <506B6024.8050908@delphij.net> <87FA4CBA-001F-4C92-8B92-D650A9678864@cederstrand.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2 October 2012 17:56, Erik Cederstrand <erik@cederstrand.dk> wrote: >> It doesn't seem hurt in general but if you are going to commit it >> please also change the other instances in the base system. I shall do so. I will probably do them in spurts > I'll do my best. There are around 200 of these in base, but some are the result of macro expansion so it may not be too bad. Please cc me on the PRs you send. I will take them all and commit them in bunches. Thanks! -- Eitan Adler
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=vyDgXfV-JM6su5BZ8QZvpBsn04_Qcig5BLoVxoyy7bA>