From owner-p4-projects@FreeBSD.ORG  Tue Dec 16 00:42:43 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 130A51065673; Tue, 16 Dec 2008 00:42:43 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CBAB51065670
	for <perforce@freebsd.org>; Tue, 16 Dec 2008 00:42:42 +0000 (UTC)
	(envelope-from piso@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id B7E2D8FC0C
	for <perforce@freebsd.org>; Tue, 16 Dec 2008 00:42:42 +0000 (UTC)
	(envelope-from piso@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id mBG0gg58055185
	for <perforce@freebsd.org>; Tue, 16 Dec 2008 00:42:42 GMT
	(envelope-from piso@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id mBG0ggnt055183
	for perforce@freebsd.org; Tue, 16 Dec 2008 00:42:42 GMT
	(envelope-from piso@freebsd.org)
Date: Tue, 16 Dec 2008 00:42:42 GMT
Message-Id: <200812160042.mBG0ggnt055183@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	piso@freebsd.org using -f
From: Paolo Pisati <piso@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 154755 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Dec 2008 00:42:43 -0000

http://perforce.freebsd.org/chv.cgi?CH=154755

Change 154755 by piso@piso_newluxor on 2008/12/16 00:42:17

	leave a comment about a bug left in UdpAliasIn: the return code from find_handler() should
	be checked instead of a always 0 variable.

Affected files ...

.. //depot/projects/soc2005/libalias/sys/netinet/libalias/alias.c#86 edit

Differences ...

==== //depot/projects/soc2005/libalias/sys/netinet/libalias/alias.c#86 (text+ko) ====

@@ -789,6 +789,7 @@
 		    &original_address, &pip->ip_dst, 2);
 		pip->ip_dst = original_address;
 
+		// XXX should check error instead of r - see pre modules version rev=1.53
 		/*
 		 * If we cannot figure out the packet, ignore it.
 		 */