From owner-freebsd-current Sat Feb 24 10:31:46 2001 Delivered-To: freebsd-current@freebsd.org Received: from mailout04.sul.t-online.com (mailout04.sul.t-online.com [194.25.134.18]) by hub.freebsd.org (Postfix) with ESMTP id CAF0337B65D for ; Sat, 24 Feb 2001 10:31:41 -0800 (PST) (envelope-from D.Rock@t-online.de) Received: from fwd03.sul.t-online.com by mailout04.sul.t-online.com with smtp id 14WjTo-0007Ar-02; Sat, 24 Feb 2001 19:31:40 +0100 Received: from server.rock.net (340029380333-0001@[62.226.203.211]) by fmrl03.sul.t-online.com with esmtp id 14WjTY-0e9Pl2C; Sat, 24 Feb 2001 19:31:24 +0100 Received: from t-online.de (server [172.23.7.1]) by server.rock.net (8.11.2/8.11.2/Rock) with ESMTP id f1OIVNX91486 for ; Sat, 24 Feb 2001 19:31:23 +0100 (MET) Message-ID: <3A97FDFA.3291CB26@t-online.de> Date: Sat, 24 Feb 2001 19:31:22 +0100 From: Daniel Rock X-Mailer: Mozilla 4.76 [de] (X11; U; SunOS 5.8 i86pc) X-Accept-Language: de, en MIME-Version: 1.0 Cc: freebsd-current@FreeBSD.ORG Subject: Re: HEADS UP Re: cvs commit: src/sys/alpha/alpha trap.c src/sys/dev/acpica/Osd OsdSchedule.c src/sys/i386/i386 genassym.c swtch.strap.c src/sys/ia64/ia64 trap.c src/sys/kern init_main.c kern_condvar.ckern_idle.c kern_intr.c kern_mib.c kern_mutex.c kern_proc.c ... References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Sender: 340029380333-0001@t-dialin.net Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Bruce Evans schrieb: > > On Thu, 22 Feb 2001, Daniel Rock wrote: > > > You may have forgotten to also change KINFO_PROC_SIZE in src/sys/user.h > > Yes, rev.1.31 of src/sys/sys/user.h leaves it as an exercise to change > KINFO_PROC_SIZE. I hate doing such exercises, since it will be followed by some nasty other exercises: Clean up your conflicting cvs files... > > WARNING: size of kinfo_proc (648) should be 644!!! > > This is normal if you haven't done the exercise. It is just a warning. This seems to be a "non required" exercise, since even if you fail solving it, your machine continues working... > > BTW What is the purpose of KINFO_PROC_SIZE? Why not simply using sizeof()? > > It is to inhibit changes in the size of the struct. Such changes would > break the interface. The struct must have a certain fixed size (and > layout) for binary compatibility. sizeof() would give the current size, > not necessarily the size that is required for compatibility. But: Since the introduction of KINFO_PROC_SIZE (rev. 1.27(?) of src/sys/sys/user.h) there have been two modifications which still required to rebuild libkvm, ... Maybe many people won't use the spare entries at the end of the structure but put their additions somewhere besides some other related variables for aesthetical purposes? Which value does libkvm use? KINFO_PROC_SIZE or sizeof()? It seems it uses sizeof() since ps/top/w still work besides the warning message. -- Daniel To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message