Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 24 Apr 2023 09:43:08 GMT
From:      Vladimir Kondratyev <wulf@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 176939bd361a - main - bcm5974: fix wellspring9 pressure settings to handle force sensitivity
Message-ID:  <202304240943.33O9h8GB088271@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by wulf:

URL: https://cgit.FreeBSD.org/src/commit/?id=176939bd361a3d9c859d0c618f76b70635051d6c

commit 176939bd361a3d9c859d0c618f76b70635051d6c
Author:     Val Packett <val@packett.cool>
AuthorDate: 2023-04-24 09:41:52 +0000
Commit:     Vladimir Kondratyev <wulf@FreeBSD.org>
CommitDate: 2023-04-24 09:41:52 +0000

    bcm5974: fix wellspring9 pressure settings to handle force sensitivity
    
    Reviewed by:    wulf
    MFC after:      1 month
    Differential revision:  https://reviews.freebsd.org/D34435
---
 sys/dev/hid/bcm5974.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/sys/dev/hid/bcm5974.c b/sys/dev/hid/bcm5974.c
index 26dc5107520f..a7f2a076bc94 100644
--- a/sys/dev/hid/bcm5974.c
+++ b/sys/dev/hid/bcm5974.c
@@ -327,9 +327,15 @@ static const struct bcm5974_dev_params bcm5974_dev_params[BCM5974_FLAG_MAX] = {
 		.o = { SN_ORIENT,
 		    -MAX_FINGER_ORIENTATION, MAX_FINGER_ORIENTATION, 0 },
 	},
+	/*
+	 * NOTE: Actually force-sensitive. Pressure has a "size" equal to the max
+	 * so that the "resolution" is 1 (i.e. values will be interpreted as grams).
+	 * No scientific measurements have been done :) but a really hard press
+	 * results in a value around 3500 on model 4.
+	 */
 	[BCM5974_FLAG_WELLSPRING9] = {
 		.tp = tp + TYPE4,
-		.p = { SN_PRESSURE, 0, 300, 0 },
+		.p = { SN_PRESSURE, 0, 4096, 4096 },
 		.w = { SN_WIDTH, 0, 2048, 0 },
 		.x = { SN_COORD, -4828, 5345, 105 },
 		.y = { SN_COORD, -203, 6803, 75 },



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202304240943.33O9h8GB088271>