From nobody Tue Mar 24 10:39:11 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fg63M5qGcz6WV7c for ; Tue, 24 Mar 2026 10:39:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fg63M3Yr1z3v0S for ; Tue, 24 Mar 2026 10:39:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774348751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kWbh1CKN3KA2CbuP6tB1ERNDdQ4Awj27+9nVUGiROFs=; b=B/oNiZcv/ld5jHqTBZBYv2NohF2NCZnhxJTULjcnu8okAD/BVMTtaiCVdlgPKGel+oMiHQ S+nDEC0WpoYc3WhRhgTSKc+5qjxW8FWkN6lQlfbAdyYwOdsMekIlovPy74l+CKRNNGtxQW 2iavBdBuUdZ3yE2TkpplEcJbU7LCoCTG0yYKhDFDTcpT3xA0vWVv8KN81eG00eqKoxJbbh 5FiwWphzQ3e+RgCz3R7R437zMFRxd2TAKNNLHhnsWuFvngckgVAQiKYc3F1PuM7IH8VcEi T44ldjBa4TMaMo+Z8X+W6fJR0yGtiLzcxTvI2UqgBql7xwtU1nHOXYSo0daNBA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774348751; a=rsa-sha256; cv=none; b=mWFAFTAb+q3CFDOPnpXlBP7M9WCM5P3aIiIvAY1c4Qvvy4ybJuqp8OTskANiFOPK6C1FRt +Io1mo502dHVfIkrQVx0lMP+kfMOJJ3EK8ArCnuFrVVLi0KFS6/YE8BDBSPzTvsNSnTx+B 8U0E1o383DzRprk46RYmf5J0B58sQglCPDV07LBf/c7Vz29YqH29Te21ieapGdoIEWUSkI ve1g+IqDU5uTOvW00+S4BJ5f5wFH1cHM01HnBdoXwyKj4a7U9Q5EhVNPHPSs0OA7DXpLu3 Oy00yQi/Z6E4JERymsZcbKSmyex+pG1nXvtbbLZVFkPbHe0QDC6VFPzmVZBQlg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774348751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kWbh1CKN3KA2CbuP6tB1ERNDdQ4Awj27+9nVUGiROFs=; b=I7lzOCCxXjC5Lckr0J3A1QqdqyYeN8pbygu3fTYh+rP2ozn8z3NYnjSVkGhR/xCBVzzq0p jWBwox9TaEyqhg8Be3wH3wZB4HBmUKBDeitL6A9jppYKIqoxtZxFsJ/tpR+yjRxu2XZVW8 xGxxuOkkucJVfvSOyyzynhkN3GPwM4RuvR650PdrKSHeTe3CQ8hSuNfAN/Cv8qj/bN9896 0K1ek33MyDmvgQy9cFpls5T2zhPL5uXJUfc7u6iQaOsriM1jPGhxnXioYBZwH4HaMpTYwo o1uDUzwTTeIccOYPRV9xG9EWO23d6JsiJe8pOmSZ8LNpnT8Lvrdha5a3HFKPhQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fg63M38nQzVc for ; Tue, 24 Mar 2026 10:39:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 33f46 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 24 Mar 2026 10:39:11 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: edad981e1e86 - main - sound: Address some XXX comments regarding AC'97 IDs List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: edad981e1e8673b6dd14656fe75b9f239fb777ce Auto-Submitted: auto-generated Date: Tue, 24 Mar 2026 10:39:11 +0000 Message-Id: <69c269cf.33f46.3ca98a22@gitrepo.freebsd.org> The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=edad981e1e8673b6dd14656fe75b9f239fb777ce commit edad981e1e8673b6dd14656fe75b9f239fb777ce Author: Christos Margiolis AuthorDate: 2026-03-24 10:32:31 +0000 Commit: Christos Margiolis CommitDate: 2026-03-24 10:38:41 +0000 sound: Address some XXX comments regarding AC'97 IDs These seem harmless to address. Not sure why the original author did not just assign the appropriate names if he knew they were wrong. Sponsored by: The FreeBSD Foundation MFC after: 1 week Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D56044 --- sys/dev/sound/pcm/ac97.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/sys/dev/sound/pcm/ac97.c b/sys/dev/sound/pcm/ac97.c index 14ff2f6a62ab..85f1f7ccf4d0 100644 --- a/sys/dev/sound/pcm/ac97.c +++ b/sys/dev/sound/pcm/ac97.c @@ -125,12 +125,7 @@ static const struct ac97_vendorid ac97vendorid[] = { { 0x57454300, "Winbond" }, { 0x574d4c00, "Wolfson" }, { 0x594d4800, "Yamaha" }, - /* - * XXX This is a fluke, really! The real vendor - * should be SigmaTel, not this! This should be - * removed someday! - */ - { 0x01408300, "Creative" }, + { 0x01408300, "SigmaTel" }, { 0x00000000, NULL } }; @@ -238,12 +233,7 @@ static struct ac97_codecid ac97codecid[] = { { 0x594d4800, 0x00, 0, "YMF743", 0 }, { 0x594d4802, 0x00, 0, "YMF752", 0 }, { 0x594d4803, 0x00, 0, "YMF753", 0 }, - /* - * XXX This is a fluke, really! The real codec - * should be STAC9704, not this! This should be - * removed someday! - */ - { 0x01408384, 0x00, 0, "EV1938", 0 }, + { 0x01408384, 0x00, 0, "STAC9704", 0 }, { 0, 0, 0, NULL, 0 } };