Date: Sun, 14 Feb 2021 21:41:49 +0100 From: Christoph Moench-Tegeder <cmt@burggraben.net> To: Jason Bacon <bacon4000@gmail.com> Cc: "Jason W. Bacon" <jwb@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r565224 - in head/lang/pocl: . files Message-ID: <YCmLDdWH9I/fuzp9@elch.exwg.net> In-Reply-To: <bbaa5a6a-cde9-052a-e631-7acfcf9b6937@gmail.com> References: <202102141304.11ED4BTl046406@repo.freebsd.org> <YCkoTsUm1QeWBzO8@elch.exwg.net> <bbaa5a6a-cde9-052a-e631-7acfcf9b6937@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
## Jason Bacon (bacon4000@gmail.com):
> > First, while I'm all in favor of consistent white space, mixing this
> > with the stated (per commit message) change makes the diff harder
> > to read and "svn annotate" (and similar tools) harder to use later on.
> Are you suggesting that whitespace changes should be done in a separate
> commit?
Perhaps I wouldn't put it that strongly. More like "think about how that
looks like in the commit history".
This is not a policy, but some options:
- if you're changing a line anyways, fix the whitespace there at the
same time
- lines which will never or rarely change (PORTNAME, MAINTAINER, ...)
could be whitespace-fixed in their own commit
- fix the whitespace across the whole file first, then do whatever "real"
change you want to do
- depending on how much you change anyways, it might even not matter
that much if you "just fix the whitespace on the side".
The guiding principle should be to retain the usefulness of the
commit diffs and the history: searching that one "real" change in
dozens of lines of whitespace-only diff can be frustrating, and
running "{svn,git} annotate" just to end up at that one "fix whitespace"
commit also does not help.
Regards,
Christoph
--
Spare Space
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YCmLDdWH9I/fuzp9>