From owner-freebsd-current Tue Jan 21 14:46:57 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D381537B401 for ; Tue, 21 Jan 2003 14:46:56 -0800 (PST) Received: from heron.mail.pas.earthlink.net (heron.mail.pas.earthlink.net [207.217.120.189]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6141943E4A for ; Tue, 21 Jan 2003 14:46:56 -0800 (PST) (envelope-from tlambert2@mindspring.com) Received: from pool0183.cvx40-bradley.dialup.earthlink.net ([216.244.42.183] helo=mindspring.com) by heron.mail.pas.earthlink.net with asmtp (SSLv3:RC4-MD5:128) (Exim 3.33 #1) id 18b7AT-00069s-00; Tue, 21 Jan 2003 14:46:54 -0800 Message-ID: <3E2DCD8B.91E441A2@mindspring.com> Date: Tue, 21 Jan 2003 14:45:31 -0800 From: Terry Lambert X-Mailer: Mozilla 4.79 [en] (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Daniel Holmes Cc: freebsd-current@freebsd.org Subject: Re: acpi_cpu printf References: <200301211554.h0LFsKmX002682@zorkmid.dakcs.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-ELNK-Trace: b1a02af9316fbb217a47c185c03b154d40683398e744b8a48e482ca2dfbe5f48df873bfcd9df8d233ca473d225a0f487350badd9bab72f9c350badd9bab72f9c Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Daniel Holmes wrote: > > + printf("acpi_cpu: throttling enabled, %d steps from 100%% to %d.%d%%, " > > + "currently %d.%d%%\n" > > Personally, rather than 'enabled', how about 'available'? Using the > word enabled might give some newbies fits when they try to figure it > out what it means. It sounds like the throttling is already turned on. I made the same comment, originally; I think that the problem is that "enabled" is more likely to have meaning for non-English speakers than "available". You missed the second "printf", which printed out the current stepping level; I did too, when I first read it. I think that changing the order from "100% to 10%" to "10% to 100%" will, if people ignore the second printed line, imply that there was a transition from 10% to 100%, rather than the reverse (that was my response to the patch). -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message