From owner-svn-src-head@freebsd.org Tue Nov 21 01:36:36 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E4D03DBB1A5; Tue, 21 Nov 2017 01:36:36 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf0-x232.google.com (mail-lf0-x232.google.com [IPv6:2a00:1450:4010:c07::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 66A9A76787; Tue, 21 Nov 2017 01:36:36 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf0-x232.google.com with SMTP id o41so12232052lfi.2; Mon, 20 Nov 2017 17:36:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=4+dBNyQs6EvvuvdYMHCtNu7d27AX7z1EWoET2A18ZQE=; b=RvqzKlJoYOuvwHoRd1lRg49S5m6eHTgAj6kWnrbEAp4Z5phJB/reYbQdn3jSUXADRm EkGrjJatawORdYYsjicbNylBCLjYPvExuE+olXeBGVbizsIY8J8wHvhbwAt0OBoNEp21 kwRA/+t/VkKg8KxI7Uz5TjytSWh/BrNx1OvOYFJxAQ3enSTEegYetC/diDmJZpJcV8s9 0m4cOJ9Tny9oKFHVUk5hHAgHUi2Ww2NEUjTMZGx7eigNxJgPv+RJjwKYToU2gQEzgOtU 0CizgLpzmoTHYwbfjewpEG+IN22XBgmtj3VVOjIG87l0OAQ6XbYJDd4gwZA0L7hYrwCy b/Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=4+dBNyQs6EvvuvdYMHCtNu7d27AX7z1EWoET2A18ZQE=; b=UXe0wNf2W2w9T/t+O0aEokbfPVY9JWdeKzKSP4LWCZi+q2DUNB1k8laFiSThExiD0T 1/rk19SLyI57xNTscqUiU3EjjOrn67xMMT1hzHWTJqhCd3ylh16Pqic9UzEkKNeWfcjk kqaB+QoAkBLvwvRlE18UsZL4H25Q7aKRhfIKXnkhAVKaXbmUZXvhncmdEazwE/0Mq7Eq AdQLKuLp2S9YB2wIxwsGF7tTiHveOSFVdw44AJvqRXebg7X+PLFZA0+fAV15LkKFHYJ8 131+Qx0oZklgAMsuOVbOthIVrlt2IFToF9ZjArCmCkhzW4j8Ipa3iXI3y7gAWmaJSGbI 3Yeg== X-Gm-Message-State: AJaThX7G85M0Q8uQw2oYKobLxvi8/i7DLoDQKIcsVflzTQCUEhqR3F48 lSMXhihaoMhMR7R0+I3O5gZgIrT1itL9gRdO/EA= X-Google-Smtp-Source: AGs4zMbpKPrXu+0WrdwRpFYtVufAtCTHfGEwQ5cshHGzrQFhH4/5rATL20IZ2UxYHzTEs/IwBJKBrBUTM4gBepMF8NM= X-Received: by 10.46.88.4 with SMTP id m4mr5131946ljb.15.1511228194133; Mon, 20 Nov 2017 17:36:34 -0800 (PST) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.179.76.19 with HTTP; Mon, 20 Nov 2017 17:36:33 -0800 (PST) In-Reply-To: References: <201711202255.vAKMt2nP014201@repo.freebsd.org> From: Alan Somers Date: Mon, 20 Nov 2017 18:36:33 -0700 X-Google-Sender-Auth: 17Pqa5wkt8IBnc4_PDQpF2rFnkM Message-ID: Subject: Re: svn commit: r326039 - in head: etc/mtree usr.bin/head usr.bin/head/tests To: Ed Maste Cc: src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 01:36:37 -0000 On Mon, Nov 20, 2017 at 6:32 PM, Ed Maste wrote: > On 20 November 2017 at 17:55, Alan Somers wrote: >> Author: asomers >> Date: Mon Nov 20 22:55:02 2017 >> New Revision: 326039 >> URL: https://svnweb.freebsd.org/changeset/base/326039 >> >> Log: >> Add ATF tests for head(1) >> >> Submitted by: Fred Schlecter >> Reviewed by: asomers, jilles >> MFC after: 3 weeks >> Differential Revision: https://github.com/freebsd/freebsd/pull/127 > > It's certainly a good idea to capture the source of changes that come > in via GitHub pull requests, but the 'Differential Revision' field is > specifically for reviews in our own hosted Phabricator instance. > > We don't have an officially established metadata field for changes > that come in via pull requests at the moment. I'd suggest we just go > with: > Pull request: https://github.com/freebsd/freebsd/pull/127 Are there any automated tools that care about the "Differential Revision" field? If so, they should be able to tell the difference between GitHub revisions and Phabricator revisions based on the URL. Using "Differential Revision" instead of "Pull request" is handy, because it's part of the standard commit template, which encourages consistency. -Alan