From owner-svn-src-projects@freebsd.org Sat Jun 30 08:25:57 2018 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 85AA0102435E for ; Sat, 30 Jun 2018 08:25:57 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from forward103p.mail.yandex.net (forward103p.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "forwards.mail.yandex.net", Issuer "Yandex CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D23A87423A; Sat, 30 Jun 2018 08:25:56 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from mxback7g.mail.yandex.net (mxback7g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:168]) by forward103p.mail.yandex.net (Yandex) with ESMTP id AD222218660B; Sat, 30 Jun 2018 11:25:52 +0300 (MSK) Received: from smtp4j.mail.yandex.net (smtp4j.mail.yandex.net [2a02:6b8:0:1619::15:6]) by mxback7g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 6w5M9wXgj4-PqlWn7YR; Sat, 30 Jun 2018 11:25:52 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1530347152; bh=SP+HI8ndtKkEaXZgdmjTGv3tbfFow3qXoqgSZB5t+mA=; h=Subject:To:References:From:Message-ID:Date:In-Reply-To; b=eXyEJb7iKMoj6dfXys02SsAgJBpXwShjnG+4Qle08fOTWOv5GKtCb+JQOAu8VNJlH +SXZeFTpNnC4I5ysXBv4hjRg4w6+a1646yArktQdsopfQTkVGWxOsbfgfkyoC7s/Fe X6TwwA1Xci2btriweEVdLPUff2udZPnCimxgwt9A= Received: by smtp4j.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id AcRL7szujp-Pq5OHaPv; Sat, 30 Jun 2018 11:25:52 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1530347152; bh=SP+HI8ndtKkEaXZgdmjTGv3tbfFow3qXoqgSZB5t+mA=; h=Subject:To:References:From:Message-ID:Date:In-Reply-To; b=eXyEJb7iKMoj6dfXys02SsAgJBpXwShjnG+4Qle08fOTWOv5GKtCb+JQOAu8VNJlH +SXZeFTpNnC4I5ysXBv4hjRg4w6+a1646yArktQdsopfQTkVGWxOsbfgfkyoC7s/Fe X6TwwA1Xci2btriweEVdLPUff2udZPnCimxgwt9A= Authentication-Results: smtp4j.mail.yandex.net; dkim=pass header.i=@yandex.ru Subject: Re: svn commit: r335806 - projects/pnfs-planb-server/usr.sbin/nfsd To: Rick Macklem , src-committers@freebsd.org, svn-src-projects@freebsd.org References: <201806292207.w5TM7QX9052770@repo.freebsd.org> From: "Andrey V. Elsukov" Openpgp: id=E6591E1B41DA1516F0C9BC0001C5EA0410C8A17A Autocrypt: addr=bu7cher@yandex.ru; prefer-encrypt=mutual; keydata= xsBNBEwBF1kBCADB9sXFhBEUy8qQ4X63Y8eBatYMHGEFWN9ypS5lI3RE6qQW2EYbxNk7qUC5 21YIIS1mMFVBEfvR7J9uc7yaYgFCEb6Sce1RSO4ULN2mRKGHP3/Sl0ijZEjWHV91hY1YTHEF ZW/0GYinDf56sYpDDehaBF5wkWIo1+QK5nmj3vl0DIDCMNd7QEiWpyLVwECgLX2eOAXByT8B bCqVhJGcG6iFP7/B9Ll6uX5gb8thM9LM+ibwErDBVDGiOgvfxqidab7fdkh893IBCXa82H9N CNwnEtcgzh+BSKK5BgvPohFMgRwjti37TSxwLu63QejRGbZWSz3OK3jMOoF63tCgn7FvABEB AAHNIkFuZHJleSBWLiBFbHN1a292IDxhZUBmcmVlYnNkLm9yZz7CwHsEEwECACUCGwMGCwkI BwMCBhUIAgkKCwQWAgMBAh4BAheABQJMB/ruAhkBAAoJEAHF6gQQyKF6MLwH/3Ri/TZl9uo0 SepYWXOnxL6EaDVXDA+dLb1eLKC4PRBBjX29ttQ0KaWapiE6y5/AfzOPmRtHLrHYHjd/aiHX GMLHcYRXD+5GvdkK8iMALrZ28X0JXyuuZa8rAxWIWmCbYHNSBy2unqWgTI04Erodk90IALgM 9JeHN9sFqTM6zalrMnTzlcmel4kcjT3lyYw3vOKgoYLtsLhKZSbJoVVVlvRlGBpHFJI5AoYJ SyfXoN0rcX6k9X7Isp2K50YjqxV4v78xluh1puhwZyC0p8IShPrmrp9Oy9JkMX90o6UAXdGU KfdExJuGJfUZOFBTtNIMNIAKfMTjhpRhxONIr0emxxDOwE0ETAEXWQEIAJ2p6l9LBoqdH/0J PEFDY2t2gTvAuzz+8zs3R03dFuHcNbOwjvWCG0aOmVpAzkRa8egn5JB4sZaFUtKPYJEQ1Iu+ LUBwgvtXf4vWpzC67zs2dDuiW4LamH5p6xkTD61aHR7mCB3bg2TUjrDWn2Jt44cvoYxj3dz4 S49U1rc9ZPgD5axCNv45j72tggWlZvpefThP7xT1OlNTUqye2gAwQravXpZkl5JG4eOqJVIU X316iE3qso0iXRUtO7OseBf0PiVmk+wCahdreHOeOxK5jMhYkPKVn7z1sZiB7W2H2TojbmcK HZC22sz7Z/H36Lhg1+/RCnGzdEcjGc8oFHXHCxUAEQEAAcLAXwQYAQIACQUCTAEXWQIbDAAK CRABxeoEEMihegkYCAC3ivGYNe2taNm/4Nx5GPdzuaAJGKWksV+w9mo7dQvU+NmI2az5w8vw 98OmX7G0OV9snxMW+6cyNqBrVFTu33VVNzz9pnqNCHxGvj5dL5ltP160JV2zw2bUwJBYsgYQ WfyJJIM7l3gv5ZS3DGqaGIm9gOK1ANxfrR5PgPzvI9VxDhlr2juEVMZYAqPLEJe+SSxbwLoz BcFCNdDAyXcaAzXsx/E02YWm1hIWNRxanAe7Vlg7OL+gvLpdtrYCMg28PNqKNyrQ87LQ49O9 50IIZDOtNFeR0FGucjcLPdS9PiEqCoH7/waJxWp6ydJ+g4OYRBYNM0EmMgy1N85JJrV1mi5i Message-ID: <0c85d229-3b8f-3b4c-ba3c-34ec06728455@yandex.ru> Date: Sat, 30 Jun 2018 11:22:41 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <201806292207.w5TM7QX9052770@repo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wOxAZ3H2Y5wTidZlugg1gFckvddm0P1z0" X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Jun 2018 08:25:57 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wOxAZ3H2Y5wTidZlugg1gFckvddm0P1z0 Content-Type: multipart/mixed; boundary="Cy0mHi3LpMMo4xu93hEg62X8ZtHJcBV4w"; protected-headers="v1" From: "Andrey V. Elsukov" To: Rick Macklem , src-committers@freebsd.org, svn-src-projects@freebsd.org Message-ID: <0c85d229-3b8f-3b4c-ba3c-34ec06728455@yandex.ru> Subject: Re: svn commit: r335806 - projects/pnfs-planb-server/usr.sbin/nfsd References: <201806292207.w5TM7QX9052770@repo.freebsd.org> In-Reply-To: <201806292207.w5TM7QX9052770@repo.freebsd.org> --Cy0mHi3LpMMo4xu93hEg62X8ZtHJcBV4w Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 30.06.2018 01:07, Rick Macklem wrote: > Author: rmacklem > Date: Fri Jun 29 22:07:25 2018 > New Revision: 335806 > URL: https://svnweb.freebsd.org/changeset/base/335806 >=20 > Log: > Add support for IPv6 addresses to the "-p" option for the pNFS server= DS > specifications. >=20 > + char *mdspath, *mdsp, ip6[INET6_ADDRSTRLEN]; > + const char *ad; > int ecode; > + hints.ai_flags =3D AI_CANONNAME | AI_ADDRCONFIG; > + hints.ai_family =3D PF_UNSPEC; > hints.ai_socktype =3D SOCK_STREAM; > hints.ai_protocol =3D IPPROTO_TCP; > ecode =3D getaddrinfo(cp, NULL, &hints, &ai_tcp); > if (ecode !=3D 0) > err(1, "getaddrinfo pnfs: %s %s", cp, > gai_strerror(ecode)); > + memcpy(&sin6, res->ai_addr, sizeof(sin6)); > + ad =3D inet_ntop(AF_INET6, &sin6.sin6_addr, ip6, > + sizeof(ip6)); Hi, I'm unaware of applicability of IPv6 addresses with restricted scope in this area, but when you use inet_ntop() to get IPv6 address text representation, you can lost IPv6 scope zone id. getaddrinfo() can return sockaddr structure with properly filled sin6_scope_id field. It is better to use getnameinfo() with NI_NUMERICHOST flag. Also the size of ip6 buffer should be enough to keep scope specifier. --=20 WBR, Andrey V. Elsukov --Cy0mHi3LpMMo4xu93hEg62X8ZtHJcBV4w-- --wOxAZ3H2Y5wTidZlugg1gFckvddm0P1z0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEzBAEBCAAdFiEE5lkeG0HaFRbwybwAAcXqBBDIoXoFAls3PdcACgkQAcXqBBDI oXocJAf9HrU/c/Ptmk/ZCsEAaSxuT8n8sk2EPyu8H2qDW1/HIQXD3zR0p54fwHBE iuiZmnjgVG2k4dNF1zkVsTOB++Zx/2jvAyld2JZdjWWKy1HqyXLvdIWmLlzUr0u+ yOWroPhW3r+pAWAHmJ72mtIVbRj6wJBa4ItOhA22WPQVR5ZUBvUklWhqgDUMfbII o5Cgoo2YfQSNVvFiXDkey5/4AZ4cexq0iKgI5HPguc2xYsMRGJBYvLx+sCd20vKK kzh/Ua0Kh4PD2s90EDk5vjY2SNqa3MsNNkiQFuq8bNUD07Eb0LGw3Qb6YH+3iN8e bkurSxIYHPLq1OgmhCRQ3GwNLMKAEA== =Z+au -----END PGP SIGNATURE----- --wOxAZ3H2Y5wTidZlugg1gFckvddm0P1z0--