From owner-freebsd-standards@FreeBSD.ORG  Tue Jun 24 05:42:38 2003
Return-Path: <owner-freebsd-standards@FreeBSD.ORG>
Delivered-To: freebsd-standards@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6C0D037B401; Tue, 24 Jun 2003 05:42:37 -0700 (PDT)
Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2807943F3F; Tue, 24 Jun 2003 05:42:36 -0700 (PDT)
	(envelope-from ache@pobrecita.freebsd.ru)
Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1])
	by nagual.pp.ru (8.12.9/8.12.9) with ESMTP id h5OCgYt0083905;
	Tue, 24 Jun 2003 16:42:35 +0400 (MSD)
	(envelope-from ache@pobrecita.freebsd.ru)
Received: (from ache@localhost)
	by pobrecita.freebsd.ru (8.12.9/8.12.9/Submit) id h5OCgYA1083904;
	Tue, 24 Jun 2003 16:42:34 +0400 (MSD)
Date: Tue, 24 Jun 2003 16:42:34 +0400
From: Andrey Chernov <ache@nagual.pp.ru>
To: standards@FreeBSD.ORG
Message-ID: <20030624124233.GA83552@nagual.pp.ru>
References: <20030624114418.GA58305@HAL9000.homeunix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030624114418.GA58305@HAL9000.homeunix.com>
User-Agent: Mutt/1.5.4i
cc: das@FreeBSD.ORG
Subject: Re: scanf(3) patch for C99-conformant FP parsing
X-BeenThere: freebsd-standards@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Standards compliance <freebsd-standards.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-standards>,
	<mailto:freebsd-standards-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-standards>
List-Post: <mailto:freebsd-standards@freebsd.org>
List-Help: <mailto:freebsd-standards-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-standards>,
	<mailto:freebsd-standards-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Jun 2003 12:42:38 -0000

On Tue, Jun 24, 2003 at 04:44:18 -0700, David Schultz wrote:
> Outstanding issues:
> 	- I'm not sure that it's okay to use isdigit(3) and
> 	  friends in sprintf().  The standard seems to imply that
> 	  it would be okay if every digit in the C locale were
> 	  also a digit in all other locales.

isdigit() always for 0..9 only, isxdigit() is a like, don't know, what 
you mean by 'friends'.

> +				} else if (!isalnum(c) && c != '_')

F.e. isalnum() you should use with care, it may hit national characters.

BTW, in all cases calling is*() macros on char may have side effects, you 
need to promote argument to (unsigned char) first.