Date: Wed, 2 Aug 2000 21:16:26 +0200 (CEST) From: Johan Karlsson <k@numeri.campus.luth.se> To: FreeBSD-gnats-submit@freebsd.org Cc: dburr@freebsd.org Subject: ports/20364: audio/ripit-atapi can use 'dagrab' instead of broken cdd and sox Message-ID: <200008021916.VAA48505@numeri.campus.luth.se>
next in thread | raw e-mail | index | archive | help
>Number: 20364
>Category: ports
>Synopsis: audio/ripit-atapi can use 'dagrab' instead of broken cdd and sox
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Aug 02 12:20:00 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator: Johan Karlsson
>Release: FreeBSD 4.1-STABLE i386
>Organization:
>Environment:
ripit-atapi/Makefile:
$FreeBSD: ports/audio/ripit-atapi/Makefile,v 1.3 2000/04/08 21:24:20 mharo Exp $
cdd/Makefile:
$FreeBSD: ports/audio/cdd/Makefile,v 1.5 2000/06/01 15:50:14 will Exp $
dagrab/Makefile:
$FreeBSD: ports/audio/dagrab/Makefile,v 1.10 2000/04/22 21:31:57 cpiazza Exp $
>Description:
cdd is marked broken for RELENG_4 and HEAD since rev 1.5 of the Makefile.
This also makes ripit-atapi broken since it needs cdd.
However, ripit-atapi can use dagrab instead of cdd and sox.
Please, apply the attached patch for ports/audio/ripit-atapi/Makefile
and use the attached patches/patch-aa instead of the one now present.
Using these changes it works great for me :-)
>How-To-Repeat:
n/a
>Fix:
=== Makefile patch ===
--- Makefile.~1~ Tue Jun 13 19:59:34 2000
+++ Makefile Wed Aug 2 20:36:13 2000
@@ -14,9 +14,8 @@
MAINTAINER= dburr@FreeBSD.ORG
RUN_DEPENDS= bladeenc:${PORTSDIR}/audio/bladeenc \
- cdd:${PORTSDIR}/audio/cdd \
- cda:${PORTSDIR}/audio/xmcd \
- sox:${PORTSDIR}/audio/sox
+ dagrab:${PORTSDIR}/audio/dagrab \
+ cda:${PORTSDIR}/audio/xmcd
NO_BUILD= yes
USE_PERL5= yes
=======================
==== patches/patch-aa ====
--- ripit.pl.orig Tue Aug 3 00:48:31 1999
+++ ripit.pl Wed Aug 2 20:55:17 2000
@@ -27,11 +27,11 @@
#
$cddev = "/dev/cdrom"; # CD Audio device
-$outputdir = "/dosc/cdrip/"; # Where the MP3s should go
+$outputdir = "/usr/tmp/mp3/"; # Where the MP3s should go
$bitrate = 160; # Bitrate for MP3s
-$encoder = 1; # 0 - Bladeenc, 1 - Lame
+$encoder = 0; # 0 - Bladeenc, 1 - Lame
-$use_underscore = 0; # Use _ instead of spaces in filenames (1 yes, 0 no)
+$use_underscore = 1; # Use _ instead of spaces in filenames (1 yes, 0 no)
# Track template variable. Contains the format the track names will be
# written as. The '" and "' are important and must surround the template.
@@ -329,14 +329,11 @@
&printflush(RIPLOG,"Ripping $tracklist[$_ - 1]...\n");
- if (system("cdparanoia -d $cddev $riptrackno \"$riptrackname.rip\"")) {
- &printflush(RIPLOG,"cdparanoia failed on $tracklist[$_ - 1]\n");
- die "cdparanoia failed on $tracklist[$_ - 1]";
+ if (system("dagrab -d $cddev -f \"$riptrackname.wav\" $riptrackno 2>/dev/null")) {
+ &printflush(RIPLOG,"dagrab failed on $tracklist[$_ - 1]\n");
+ die "dagrab failed on $tracklist[$_ - 1]";
}
- # Rename rip file to a wav for encoder
- rename "$riptrackname.rip","$riptrackname.wav";
-
&printflush(RIPLOG,"Rip complete $tracklist[$_ - 1]\n");
# Start the Encoder in the background. but only once
@@ -367,7 +364,7 @@
print "\nMP3 Encoding track ".$ncount." of ".($#seltrack + 1)."\n";
&printflush(RIPLOG,"Encoding $tracklist[$_ - 1]...\n");
- # Keep looping until the file appears, ie wait for cdparanoia
+ # Keep looping until the file appears, ie wait for dagrab
# timeout after 30 minutes
$x=0;
while( ! -r "$riptrackname.wav" ){
============
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200008021916.VAA48505>