From owner-svn-src-head@FreeBSD.ORG  Fri Dec 17 18:22:50 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6AAF9106564A;
	Fri, 17 Dec 2010 18:22:50 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 58D658FC08;
	Fri, 17 Dec 2010 18:22:50 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id oBHIMoNu098403;
	Fri, 17 Dec 2010 18:22:50 GMT (envelope-from avg@svn.freebsd.org)
Received: (from avg@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id oBHIMouX098401;
	Fri, 17 Dec 2010 18:22:50 GMT (envelope-from avg@svn.freebsd.org)
Message-Id: <201012171822.oBHIMouX098401@svn.freebsd.org>
From: Andriy Gapon <avg@FreeBSD.org>
Date: Fri, 17 Dec 2010 18:22:50 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r216505 - head/sys/cddl/dev/cyclic/i386
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Dec 2010 18:22:50 -0000

Author: avg
Date: Fri Dec 17 18:22:50 2010
New Revision: 216505
URL: http://svn.freebsd.org/changeset/base/216505

Log:
  cyclic xcall: use smp_no_rendevous_barrier as setup function parameter
  
  In this case we call target function only on a single CPU and do not
  need any synchronization at the setup stage.
  
  It's a bit non-obvious but setup function of NULL means that
  smp_rendezvous_cpus waits for all CPUs to arrive at the rendezvous
  point, but without doing any actual setup.  While using
  smp_no_rendevous_barrier means that each CPU proceeds on its own
  schedule without any synchronization whatsoever.
  
  MFC after:	3 weeks

Modified:
  head/sys/cddl/dev/cyclic/i386/cyclic_machdep.c

Modified: head/sys/cddl/dev/cyclic/i386/cyclic_machdep.c
==============================================================================
--- head/sys/cddl/dev/cyclic/i386/cyclic_machdep.c	Fri Dec 17 16:29:06 2010	(r216504)
+++ head/sys/cddl/dev/cyclic/i386/cyclic_machdep.c	Fri Dec 17 18:22:50 2010	(r216505)
@@ -122,6 +122,6 @@ static void reprogram(cyb_arg_t arg, hrt
 static void xcall(cyb_arg_t arg, cpu_t *c, cyc_func_t func, void *param)
 {
 
-	smp_rendezvous_cpus((cpumask_t) (1 << c->cpuid), NULL,
-	    func, smp_no_rendevous_barrier, param);
+	smp_rendezvous_cpus((cpumask_t) (1 << c->cpuid),
+	    smp_no_rendevous_barrier, func, smp_no_rendevous_barrier, param);
 }