Date: Sun, 12 Jun 2022 20:02:04 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 264641] astro/merkaartor: Fix about-dialog and terminology Message-ID: <bug-264641-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D264641 Bug ID: 264641 Summary: astro/merkaartor: Fix about-dialog and terminology Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: dev2@heesakkers.info Created attachment 234648 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D234648&action= =3Dedit patch As the maintainer for Merkaartor, I received a report from a user. The About-dialog in his case shows a curious string as the Merkaartor version. There is code to determine this by running `git describe`. I'm not sure whe= ther he installed the pkg or build the port, but the GH distfile download doesn't qualify as a git repo, so it really makes no sense for the FreeBSD port to = rely on git and, as we see here, potentially mess up the version string. So for the purpose of getting a reliable string in the about-dialog I've decided to get rid of the `git describe` lines in Config.prio. Also, while I'm here, I might as well include the terminology-fix from https://github.com/openstreetmap/merkaartor/pull/260, since I have no idea = how long it will be before upstream decides to make a new release. Poudriere build: https://heesakkers.info/showandtell/merkaartor-0.19.0_4.log Package (showing the correct string) https://heesakkers.info/showandtell/merkaartor-0.19.0_4.pkg Credits for reporting: Friedrich Volkmann --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-264641-7788>