From owner-svn-src-projects@freebsd.org Fri Mar 15 19:56:24 2019 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8AA2D152D259 for ; Fri, 15 Mar 2019 19:56:24 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DAF5280D5B; Fri, 15 Mar 2019 19:56:23 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lj1-f180.google.com with SMTP id n18so7041048ljg.11; Fri, 15 Mar 2019 12:56:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=71eaHvyw1d63bZaKJaYf71N0bfgDtIW8bKXnQoQk4YQ=; b=XPbpDWOCXYAgLeuyee+hrCgVtRNrTjoX1aRxIY15Lxe/O48gpa7iSc9+r5d99VChpy PzDaCAbNbkQ53VcX7yMrmUt+pYYLaRmxy8lPiBxJLMO2VCY5jGSZRJve12okHAkuPrWH /+4oibxlPnA3mG7i1EbhKPy97VVXi1thjLI6cQU5qKJ8p6ZRAZGuDLhL4a1A0Jm+JA20 yEcn1zZy+ndhai5u/OFDQ5a3MY5kn81hOaa6lK9fg6im8gJRe7vSk38FLED7xZNUhW3M ndQmAUcIbl0zn8PQeZHehkTwKSgvfGLqkJjeEUL1V/8lLQAm7NJobWlkXHp7KTKjyQuG dtMQ== X-Gm-Message-State: APjAAAUBBamWVTRmDxk0edW2BGCmtlHBhYbJSoFSprJsB9RKsmvQTdda 2oqvKSN2AsyRIGs1+epvjlU2v/XqxyJmzRn5Tuk1tA== X-Google-Smtp-Source: APXvYqxlAwKgBgzoUkudslac1pl7BzYvRsu5rLuSm+pnBOTpS6e+6hrc+RQbdw7YlI7+OmIfYq+QV6zdsvNE/T9JeZU= X-Received: by 2002:a2e:9c10:: with SMTP id s16mr3215796lji.20.1552677854396; Fri, 15 Mar 2019 12:24:14 -0700 (PDT) MIME-Version: 1.0 References: <201903151850.x2FIoas1001666@repo.freebsd.org> <20190315192245.GD96870@kib.kiev.ua> In-Reply-To: <20190315192245.GD96870@kib.kiev.ua> From: Alan Somers Date: Fri, 15 Mar 2019 13:24:02 -0600 Message-ID: Subject: Re: svn commit: r345198 - projects/fuse2/share/man/man9 To: Konstantin Belousov Cc: src-committers , svn-src-projects@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: DAF5280D5B X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.969,0]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2019 19:56:24 -0000 On Fri, Mar 15, 2019 at 1:22 PM Konstantin Belousov wrote: > > On Fri, Mar 15, 2019 at 06:50:36PM +0000, Alan Somers wrote: > > Author: asomers > > Date: Fri Mar 15 18:50:36 2019 > > New Revision: 345198 > > URL: https://svnweb.freebsd.org/changeset/base/345198 > > > > Log: > > VOP_INACTIVE(9): clarify wording > > > > Reviewed by: kib, 0mp > > MFC after: 2 weeks > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D19596 > > > > Modified: > > projects/fuse2/share/man/man9/VOP_INACTIVE.9 > > > > Modified: projects/fuse2/share/man/man9/VOP_INACTIVE.9 > > ============================================================================== > > --- projects/fuse2/share/man/man9/VOP_INACTIVE.9 Fri Mar 15 18:50:00 2019 (r345197) > > +++ projects/fuse2/share/man/man9/VOP_INACTIVE.9 Fri Mar 15 18:50:36 2019 (r345198) > > @@ -28,7 +28,7 @@ > > .\" > > .\" $FreeBSD$ > > .\" > > -.Dd July 27, 2014 > > +.Dd March 15, 2019 > > .Dt VOP_INACTIVE 9 > > .Os > > .Sh NAME > > @@ -50,13 +50,16 @@ The vnode being reclaimed. > > .El > > .Pp > > .Fn VOP_INACTIVE > > -is called when the kernel is no longer using the vnode. > > +is usually called when the kernel is no longer using the vnode. > > +However, there is no guarantee that it will be called at all, for example if > > +the last reference was dropped while the vnode lock could not be upgraded > > +to exclusive without sleeping. > > This may be > > because the reference count reaches zero or it may be that the > > file system is being forcibly unmounted while there are open files. > > -It can be used to reclaim space for > > +It can be used to reclaim space on the last close of an > > .Sq open but deleted > > -files. > > +file. > > .Pp > > .Fn VOP_RECLAIM > > is called when a vnode is being reused for a different file system. > Why did you committed to the branch ? I do not think it is on-topic there, > and would like to see the wording fixes propagated back to stable branches. > I.e. even if you merge this to HEAD in some future, I do not think it is > easy to merge to stable-XX from there as part of the large commit. Because I forgot that I had the branch checked out instead of head. I'll merge it to head soon, and then it will be treated like any other head commit. -Alan