From owner-freebsd-gnome@FreeBSD.ORG Sat Mar 24 04:20:50 2012 Return-Path: Delivered-To: gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F3C7E106566B for ; Sat, 24 Mar 2012 04:20:49 +0000 (UTC) (envelope-from Cy.Schubert@komquats.com) Received: from idcmail-mo2no.shaw.ca (idcmail-mo2no.shaw.ca [64.59.134.9]) by mx1.freebsd.org (Postfix) with ESMTP id BE23E8FC08 for ; Sat, 24 Mar 2012 04:20:49 +0000 (UTC) Received: from lb7f8hsrpno-svcs.dcs.int.inet (HELO pd6ml2no-ssvc.prod.shaw.ca) ([10.0.144.222]) by pd7mo1no-svcs.prod.shaw.ca with ESMTP; 23 Mar 2012 22:20:42 -0600 X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=oQE6vNJ3d7oTBHj4PDKYH99BAdyPlqTp0xAtaaBYR4E= c=1 sm=1 a=QrugwKR0C_UA:10 a=wAGQQ9Az6v0A:10 a=BLceEmwcHowA:10 a=ICAaq7hcmGcA:10 a=kj9zAlcOel0A:10 a=IbtKDeXwb2+SRU442/pi3A==:17 a=aiIX5UjjAAAA:8 a=iE-e0aDHAAAA:8 a=BWvPGDcYAAAA:8 a=6I5d2MoRAAAA:8 a=VDf1m05jTSi3P8JwPUcA:9 a=YPae2YjZHd0hxj8uhtUA:7 a=CjuIK1q_8ugA:10 a=V7tsTZBp22UA:10 a=SV7veod9ZcQA:10 a=HpAAvcLHHh0Zw7uRqdWCyQ==:117 Received: from unknown (HELO spqr.komquats.com) ([96.50.7.119]) by pd6ml2no-dmz.prod.shaw.ca with ESMTP; 23 Mar 2012 22:20:42 -0600 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 7BB0A80 for ; Fri, 23 Mar 2012 21:20:42 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.14.5/8.14.5) with ESMTP id q2O4KgYC049011 for ; Fri, 23 Mar 2012 21:20:42 -0700 (PDT) (envelope-from Cy.Schubert@komquats.com) Message-Id: <201203240420.q2O4KgYC049011@slippy.cwsent.com> X-Mailer: exmh version 2.7.2 01/07/2005 with nmh-1.3 From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.komquats.com/ To: gnome@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 23 Mar 2012 21:20:42 -0700 Cc: Subject: gnome-terminal Bug 646317 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Cy Schubert List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Mar 2012 04:20:50 -0000 Gnome bugzilla bug 646317 (https://bugzilla.gnome.org/show_bug.cgi?id=646317 ) addresses a bug in gnome-terminal in which it returns an invalid exit status causing some environments (e.g. e17) to complain (http://trac.enlightenment.org/e/ticket/823). Would anyone mind if I committed the following patch, obtained from https://bugzilla.gnome.org/show _bug.cgi?id=646317, to gnome-terminal? Index: Makefile =================================================================== RCS file: /home/pcvs/ports/x11/gnome-terminal/Makefile,v retrieving revision 1.72 diff -u -r1.72 Makefile --- Makefile 23 Sep 2011 22:26:11 -0000 1.72 +++ Makefile 24 Mar 2012 04:12:38 -0000 @@ -8,6 +8,7 @@ PORTNAME= gnome-terminal PORTVERSION= 2.32.1 +PORTREVISION= 1 CATEGORIES= x11 gnome MASTER_SITES= GNOME DIST_SUBDIR= gnome2 Index: files/patch-src-terminal.c =================================================================== RCS file: files/patch-src-terminal.c diff -N files/patch-src-terminal.c --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ files/patch-src-terminal.c 24 Mar 2012 04:12:38 -0000 @@ -0,0 +1,11 @@ +--- src/terminal.c.orig 2010-11-10 10:47:14.000000000 -0800 ++++ src/terminal.c 2012-03-23 21:10:08.520503912 -0700 +@@ -579,7 +579,7 @@ + data = g_new (OwnData, 1); + data->factory_name = get_factory_name_for_display (display_name); + data->options = options; +- data->exit_code = -1; ++ data->exit_code = EXIT_SUCCESS; + data->argv = argv_copy; + data->argc = argc_copy; + -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.