From owner-freebsd-bugs@FreeBSD.ORG  Wed Aug 10 15:10:18 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id F01B216A420
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 10 Aug 2005 15:10:18 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 051F643D49
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 10 Aug 2005 15:10:17 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j7AFAHQT032440
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 10 Aug 2005 15:10:17 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j7AFAHTI032439;
	Wed, 10 Aug 2005 15:10:17 GMT (envelope-from gnats)
Resent-Date: Wed, 10 Aug 2005 15:10:17 GMT
Resent-Message-Id: <200508101510.j7AFAHTI032439@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	James Juran <James.Juran@baesystems.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E42FF16A41F
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed, 10 Aug 2005 15:08:06 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B641543D48
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed, 10 Aug 2005 15:08:06 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j7AF86Nl039908
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 10 Aug 2005 15:08:06 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id j7AF86od039907;
	Wed, 10 Aug 2005 15:08:06 GMT (envelope-from nobody)
Message-Id: <200508101508.j7AF86od039907@www.freebsd.org>
Date: Wed, 10 Aug 2005 15:08:06 GMT
From: James Juran <James.Juran@baesystems.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-2.3
Cc: 
Subject: kern/84761: shutdown() of non-connected socket should fail with
	ENOTCONN
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Aug 2005 15:10:19 -0000


>Number:         84761
>Category:       kern
>Synopsis:       shutdown() of non-connected socket should fail with ENOTCONN
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 10 15:10:17 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     James Juran
>Release:        5.3-RELEASE
>Organization:
BAE Systems Inc.
>Environment:
FreeBSD bsdv6 5.3-RELEASE FreeBSD 5.3-RELEASE #0: Fri Nov  5 04:19:18 UTC 2004
root@harlow.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
Calling shutdown(2) on a non-connected socket should fail with ENOTCONN
according to the manpage.  Instead, it succeeds.

>How-To-Repeat:
Run this program.  It should hit the perror(), but instead prints
"shutdown succeeded".

#include <stdio.h>
#include <stdlib.h>
#include <sys/socket.h>

int main(void)
{
    int s;

    s = socket(PF_INET, SOCK_STREAM, 0);
    if (s == -1)
    {
        perror("socket");
        exit(1);
    }

    if (shutdown(s, SHUT_RD) == -1)
        perror("shutdown");
    else
        printf("shutdown succeeded\n");

    return 0;
}

>Fix:
Check for SS_ISCONNECTED in soshutdown, and return ENOTCONN if it
is not set.

>Release-Note:
>Audit-Trail:
>Unformatted: