From nobody Wed Oct 12 15:56:23 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MnchR4R6gz4fdX1; Wed, 12 Oct 2022 15:56:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MnchR3NPjz3Lcb; Wed, 12 Oct 2022 15:56:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665590183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PVTGgOIwAdFooWoug2hNdilHO8sBWVZ+M5Ol0F+QhT8=; b=vUj1RSUfmYJ6CaruS5goFKwEgX5/0+ZhR7jz2jPvz0TAP2jwlwhhvPuPjSGBZvkzf3h8ZE oiMpliU6b8TZq5xu040ICxzntMpkiiqFvMNkWgACiu/kYDa/nXq+LAz0e+KsR8CsfeUmKY n/OjClGepXmSDW9n4zGQXDf2vH1EQZJ1DHo5YevxaME0xDPzqZOv1yYHKgZgcQTykXcN10 KA0WITthN5kMrDRdUEzkOgFMrjDvORH/tBizyM6Ax7cIXVcxcwW3117qpNetaYqwaph5rF cRnn+m0AZS7j9HS2Qhy+JGlFu6Cdf58FTw6xNRHobNJHjTYczFTS8hphFfP4Rg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MnchR2RD9z1MPj; Wed, 12 Oct 2022 15:56:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 29CFuNLq044435; Wed, 12 Oct 2022 15:56:23 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 29CFuNi5044434; Wed, 12 Oct 2022 15:56:23 GMT (envelope-from git) Date: Wed, 12 Oct 2022 15:56:23 GMT Message-Id: <202210121556.29CFuNi5044434@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Hans Petter Selasky Subject: git: 87d762392635 - stable/12 - libusb(3): Implement libusb_interrupt_event_handler() by exposing existing function. List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: hselasky X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: 87d762392635ea95dedd5a837650cc783e8c0d3e Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665590183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PVTGgOIwAdFooWoug2hNdilHO8sBWVZ+M5Ol0F+QhT8=; b=gSjhENAA056boFQN9LHs7qo0ooKeztGbs73/EBMxFUUEkwDlKywL4+5FkjBhKiqZAGcIYv WTzWxdDaaskksSssKgdKqj75RbHbqJE40WC6zmN9biVCLlQdaFaQs6pWc4LnIa46E5kEgr ftoYEwFn0J+cZnQLWbPXCx9kh+J07Z5DtzCosoFhIxs1pt0mjDv4oPofqMPQ44nAU2JV5f 1CEs4cvQUFRp8xjxVPRgZyuWUX5b4My4v0bIUkbt/ZpD8hpBX8AP/Rdn06vweOMkhkEgC0 ROjGRL+59xqF2ZhIJQMQDroW4NJct4JDA+BR3hY7k2mkP0Bn2871iOj08mrvew== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1665590183; a=rsa-sha256; cv=none; b=QYLSpZVtytAqm2aLKEsSwGmPwX0ImnJFqMOmgU/DYKxIs1KiC5nnSuJ4vfroZtsOgNe7HS 7DTcYBbbiL5qeJSUQa+LXVSC7iRGHunNy85LVaNN312rJyiUkIPv04zn23k19hcn5TLWfC TG/jJUkV4dg1FabErqtMh/xNjDeag+TLbzxt7rVZpXQ06prUhDjiFVOaH3adKnWicXAHbd TLeEqn2xoYzco13LeC38goHHLwet/QZjnmQaZr1pUb8Y5ay1+4Led37VwohrPx/zpbrHSD yuPNK2ZOdMpP+t2i4gMB2LNj7mGztXIUHS9aBqqZDeLloRYfiiNMfboEJANuSQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by hselasky: URL: https://cgit.FreeBSD.org/src/commit/?id=87d762392635ea95dedd5a837650cc783e8c0d3e commit 87d762392635ea95dedd5a837650cc783e8c0d3e Author: Hans Petter Selasky AuthorDate: 2022-10-02 15:30:40 +0000 Commit: Hans Petter Selasky CommitDate: 2022-10-12 15:55:44 +0000 libusb(3): Implement libusb_interrupt_event_handler() by exposing existing function. Sponsored by: NVIDIA Networking (cherry picked from commit aa87aa52326be7b726664dba65e91ec3d8160f48) --- lib/libusb/Makefile | 1 + lib/libusb/libusb.3 | 13 ++++++++++--- lib/libusb/libusb.h | 1 + lib/libusb/libusb10.c | 22 +++++++++++++--------- 4 files changed, 25 insertions(+), 12 deletions(-) diff --git a/lib/libusb/Makefile b/lib/libusb/Makefile index 1bbf96c0d239..96415639ab4f 100644 --- a/lib/libusb/Makefile +++ b/lib/libusb/Makefile @@ -137,6 +137,7 @@ MLINKS += libusb.3 libusb_lock_events.3 MLINKS += libusb.3 libusb_unlock_events.3 MLINKS += libusb.3 libusb_event_handling_ok.3 MLINKS += libusb.3 libusb_event_handler_active.3 +MLINKS += libusb.3 libusb_interrupt_event_handler.3 MLINKS += libusb.3 libusb_lock_event_waiters.3 MLINKS += libusb.3 libusb_unlock_event_waiters.3 MLINKS += libusb.3 libusb_wait_for_event.3 diff --git a/lib/libusb/libusb.3 b/lib/libusb/libusb.3 index 0d0e2b1a4ef1..d4c638d986e4 100644 --- a/lib/libusb/libusb.3 +++ b/lib/libusb/libusb.3 @@ -1,8 +1,6 @@ .\" .\" Copyright (c) 2009 Sylvestre Gallon .\" -.\" All rights reserved. -.\" .\" Redistribution and use in source and binary forms, with or without .\" modification, are permitted provided that the following conditions .\" are met: @@ -26,7 +24,7 @@ .\" .\" $FreeBSD$ .\" -.Dd June 9, 2020 +.Dd October, 2, 2022 .Dt LIBUSB 3 .Os .Sh NAME @@ -604,6 +602,15 @@ Returns 1 if there is a thread handling events and 0 if there are no threads currently handling events. .Pp .Ft void +.Fn libusb_interrupt_event_handler "libusb_context *ctx" +Causes the +.Fn libusb_handle_events +familiy of functions to return to the caller one time. +The +.Fn libusb_handle_events +functions may be called again after calling this function. +.Pp +.Ft void .Fn libusb_lock_event_waiters "libusb_context *ctx" Acquire the event_waiters lock. This lock is designed to be obtained in the diff --git a/lib/libusb/libusb.h b/lib/libusb/libusb.h index 3d353402ea06..9eaee671b8b3 100644 --- a/lib/libusb/libusb.h +++ b/lib/libusb/libusb.h @@ -550,6 +550,7 @@ void libusb_lock_events(libusb_context * ctx); void libusb_unlock_events(libusb_context * ctx); int libusb_event_handling_ok(libusb_context * ctx); int libusb_event_handler_active(libusb_context * ctx); +void libusb_interrupt_event_handler(libusb_context *ctx); void libusb_lock_event_waiters(libusb_context * ctx); void libusb_unlock_event_waiters(libusb_context * ctx); int libusb_wait_for_event(libusb_context * ctx, struct timeval *tv); diff --git a/lib/libusb/libusb10.c b/lib/libusb/libusb10.c index ffe0cf3f366a..d7fc7e3928db 100644 --- a/lib/libusb/libusb10.c +++ b/lib/libusb/libusb10.c @@ -115,12 +115,16 @@ libusb_set_nonblocking(int f) fcntl(f, F_SETFL, flags); } -static void -libusb10_wakeup_event_loop(libusb_context *ctx) +void +libusb_interrupt_event_handler(libusb_context *ctx) { - uint8_t dummy = 0; + uint8_t dummy; int err; + if (ctx == NULL) + return; + + dummy = 0; err = write(ctx->ctrl_pipe[1], &dummy, sizeof(dummy)); if (err < (int)sizeof(dummy)) { /* ignore error, if any */ @@ -542,7 +546,7 @@ libusb_open(libusb_device *dev, libusb_device_handle **devh) POLLOUT | POLLRDNORM | POLLWRNORM); /* make sure our event loop detects the new device */ - libusb10_wakeup_event_loop(ctx); + libusb_interrupt_event_handler(ctx); *devh = pdev; @@ -611,7 +615,7 @@ libusb_close(struct libusb20_device *pdev) libusb_unref_device(dev); /* make sure our event loop detects the closed device */ - libusb10_wakeup_event_loop(ctx); + libusb_interrupt_event_handler(ctx); } libusb_device * @@ -1440,7 +1444,7 @@ found: failure: libusb10_complete_transfer(pxfer0, sxfer, LIBUSB_TRANSFER_ERROR); /* make sure our event loop spins the done handler */ - libusb10_wakeup_event_loop(dev->ctx); + libusb_interrupt_event_handler(dev->ctx); } /* The following function must be called unlocked */ @@ -1552,7 +1556,7 @@ libusb_cancel_transfer(struct libusb_transfer *uxfer) libusb10_complete_transfer(NULL, sxfer, LIBUSB_TRANSFER_CANCELLED); /* make sure our event loop spins the done handler */ - libusb10_wakeup_event_loop(dev->ctx); + libusb_interrupt_event_handler(dev->ctx); } else if (pxfer0 == NULL || pxfer1 == NULL) { /* not started */ retval = LIBUSB_ERROR_NOT_FOUND; @@ -1563,7 +1567,7 @@ libusb_cancel_transfer(struct libusb_transfer *uxfer) /* clear transfer pointer */ libusb20_tr_set_priv_sc1(pxfer0, NULL); /* make sure our event loop spins the done handler */ - libusb10_wakeup_event_loop(dev->ctx); + libusb_interrupt_event_handler(dev->ctx); } else { libusb20_tr_stop(pxfer0); /* make sure the queue doesn't stall */ @@ -1577,7 +1581,7 @@ libusb_cancel_transfer(struct libusb_transfer *uxfer) /* clear transfer pointer */ libusb20_tr_set_priv_sc1(pxfer1, NULL); /* make sure our event loop spins the done handler */ - libusb10_wakeup_event_loop(dev->ctx); + libusb_interrupt_event_handler(dev->ctx); } else { libusb20_tr_stop(pxfer1); /* make sure the queue doesn't stall */