From owner-svn-src-all@FreeBSD.ORG Mon Aug 30 23:28:29 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DE37B1065697; Mon, 30 Aug 2010 23:28:29 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id 41DD48FC0C; Mon, 30 Aug 2010 23:28:18 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 0298045E5C; Tue, 31 Aug 2010 01:28:16 +0200 (CEST) Received: from localhost (chello089077043238.chello.pl [89.77.43.238]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 977BD45CBA; Tue, 31 Aug 2010 01:28:11 +0200 (CEST) Date: Tue, 31 Aug 2010 01:28:03 +0200 From: Pawel Jakub Dawidek To: Kostik Belousov Message-ID: <20100830232803.GH1871@garage.freebsd.pl> References: <201008300006.o7U065Nu078151@svn.freebsd.org> <20100830075945.GS2396@deviant.kiev.zoral.com.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GlnCQLZWzqLRJED8" Content-Disposition: inline In-Reply-To: <20100830075945.GS2396@deviant.kiev.zoral.com.ua> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT amd64 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r211982 - head/sbin/hastd X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Aug 2010 23:28:30 -0000 --GlnCQLZWzqLRJED8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 30, 2010 at 10:59:45AM +0300, Kostik Belousov wrote: > On Mon, Aug 30, 2010 at 12:06:05AM +0000, Pawel Jakub Dawidek wrote: > > Author: pjd > > Date: Mon Aug 30 00:06:05 2010 > > New Revision: 211982 > > URL: http://svn.freebsd.org/changeset/base/211982 > >=20 > > Log: > > Use sigtimedwait(2) for signals handling in primary process. > > This fixes various races and eliminates use of pthread* API in signal= handler. >=20 > Replying to the random commit. >=20 > In the multithreaded process, after the fork in the child, you shall > not call any not async-signal safe functions. I suppose that hook_execv() > exposes the issue, calling into some stdio functions and sysconf(). Right. It should be fixed it in r212038. Now all the hooks are executed from the main (non-threaded) process. This also makes it easier to drop privs in the worker processes in the future, now that we don't execute anything from them. Thanks for pointing that out. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --GlnCQLZWzqLRJED8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkx8PoIACgkQForvXbEpPzRgjACgxouY3EPKScws4IQGPMSPuagc vlQAoNlTU0Hkcaunc+Le6y3yr9jhGqgo =g1Ws -----END PGP SIGNATURE----- --GlnCQLZWzqLRJED8--