From owner-svn-src-all@FreeBSD.ORG Tue Jun 9 06:44:41 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5FF7B8D0; Tue, 9 Jun 2015 06:44:41 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail105.syd.optusnet.com.au (mail105.syd.optusnet.com.au [211.29.132.249]) by mx1.freebsd.org (Postfix) with ESMTP id 254181B14; Tue, 9 Jun 2015 06:44:40 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from c211-30-166-197.carlnfd1.nsw.optusnet.com.au (c211-30-166-197.carlnfd1.nsw.optusnet.com.au [211.30.166.197]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 6068610414E8; Tue, 9 Jun 2015 16:44:31 +1000 (AEST) Date: Tue, 9 Jun 2015 16:44:31 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Dimitry Andric cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r284167 - head/sys/i386/i386 In-Reply-To: <201506082012.t58KCjZX023061@svn.freebsd.org> Message-ID: <20150609162836.C935@besplex.bde.org> References: <201506082012.t58KCjZX023061@svn.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.1 cv=ItbjC+Lg c=1 sm=1 tr=0 a=KA6XNC2GZCFrdESI5ZmdjQ==:117 a=PO7r1zJSAAAA:8 a=kj9zAlcOel0A:10 a=JzwRw_2MAAAA:8 a=iSANVGSYhD-gETNt8c4A:9 a=CjuIK1q_8ugA:10 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2015 06:44:41 -0000 On Mon, 8 Jun 2015, Dimitry Andric wrote: > Log: > Merge r283870 from amd64: > > Remove unneeded NULL checks in trap_fatal(). > > Since td_name is an array member of struct thread, it can never be NULL, > so the check can be removed. In addition, curproc can never be NULL, > so remove the if statement, and splice the two printfs() together. > > While here, remove the u_long cast, and use the correct printf format > specifier for curproc->p_pid. > > Requested by: jhb Er. I gave a longer review which implicity requested not doing all of this. The format was correct (it matched the cast), and the cast was less wrong than not casting. Both amd64/trap.c i386/trap.c still print pids portably (by casting to long) in one place. They each had 2 unportable printings of pids; now they each have 3 unportable printings of pids. Bruce