From owner-cvs-src@FreeBSD.ORG Fri Apr 11 05:00:32 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 74C801065672 for ; Fri, 11 Apr 2008 05:00:32 +0000 (UTC) (envelope-from jroberson@jroberson.net) Received: from wf-out-1314.google.com (wf-out-1314.google.com [209.85.200.170]) by mx1.freebsd.org (Postfix) with ESMTP id 5452B8FC1C for ; Fri, 11 Apr 2008 05:00:32 +0000 (UTC) (envelope-from jroberson@jroberson.net) Received: by wf-out-1314.google.com with SMTP id 25so315416wfa.7 for ; Thu, 10 Apr 2008 22:00:32 -0700 (PDT) Received: by 10.142.43.7 with SMTP id q7mr695618wfq.277.1207890031973; Thu, 10 Apr 2008 22:00:31 -0700 (PDT) Received: from ?10.0.1.199? ( [24.94.72.120]) by mx.google.com with ESMTPS id 22sm4519884wfg.15.2008.04.10.22.00.29 (version=SSLv3 cipher=OTHER); Thu, 10 Apr 2008 22:00:30 -0700 (PDT) Date: Thu, 10 Apr 2008 19:01:34 -1000 (HST) From: Jeff Roberson X-X-Sender: jroberson@desktop To: Marcel Moolenaar In-Reply-To: Message-ID: <20080410190028.U43186@desktop> References: <200804110326.m3B3QfjL095474@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, Jeff Roberson , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 intr_machdep.c src/sys/arm/arm intr.c src/sys/i386/i386 intr_machdep.c src/sys/ia64/ia64 interrupt.c src/sys/kern kern_cpuset.c kern_intr.c src/sys/powerpc/powerpc intr_machdep.c src/sys/sparc64/sparc64 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Apr 2008 05:00:32 -0000 On Thu, 10 Apr 2008, Marcel Moolenaar wrote: > > On Apr 10, 2008, at 8:26 PM, Jeff Roberson wrote: >> jeff 2008-04-11 03:26:41 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/amd64/amd64 intr_machdep.c >> sys/arm/arm intr.c >> sys/i386/i386 intr_machdep.c >> sys/ia64/ia64 interrupt.c >> sys/kern kern_cpuset.c kern_intr.c >> sys/powerpc/powerpc intr_machdep.c >> sys/sparc64/sparc64 intr_machdep.c >> sys/sun4v/sun4v intr_machdep.c >> sys/sys cpuset.h interrupt.h >> Log: >> - Add the interrupt vector number to intr_event_create so MI code can >> lookup hard interrupt events by number. Ignore the irq# for soft intrs. > > JFYI: vectors are not the same as hard interrupt numbers. > On ia64 they imply priority, which means that vector > numbers should be selected for their priority and not > have a 1-to-1 mapping with IRQ number. > On powerpc they mean absolutely nothing other than being > an index into an array. > > It's better to use IRQs and not vectors to lookup int. > events by number. I think I mixed my terminology in the commit. I meant for all architectures to pass in the number that would appear in vmstat -i. Can you verify that this is what I did for powerpc and ia64? Thanks, Jeff > > FYI, > > -- > Marcel Moolenaar > xcllnt@mac.com >