Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 10 Apr 2021 06:02:05 GMT
From:      Mateusz Guzik <mjg@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: c3437848d868 - stable/13 - devfs: fix use count leak when using TIOCSCTTY
Message-ID:  <202104100602.13A625Cj015183@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by mjg:

URL: https://cgit.FreeBSD.org/src/commit/?id=c3437848d8683f6ad03a15bde201c4ead541378e

commit c3437848d8683f6ad03a15bde201c4ead541378e
Author:     Mateusz Guzik <mjg@FreeBSD.org>
AuthorDate: 2021-02-08 22:10:57 +0000
Commit:     Mateusz Guzik <mjg@FreeBSD.org>
CommitDate: 2021-04-10 05:57:55 +0000

    devfs: fix use count leak when using TIOCSCTTY
    
    by matching devfs_ctty_ref
    
    Fixes: 3b44443626603f65 ("devfs: rework si_usecount to track opens")
    (cherry picked from commit 3bc17248d31794519ba95b2c6b9ff8a0d31dba81)
---
 sys/fs/devfs/devfs_vnops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/fs/devfs/devfs_vnops.c b/sys/fs/devfs/devfs_vnops.c
index 983bfc803999..043cee74fde2 100644
--- a/sys/fs/devfs/devfs_vnops.c
+++ b/sys/fs/devfs/devfs_vnops.c
@@ -974,7 +974,7 @@ devfs_ioctl(struct vop_ioctl_args *ap)
 
 		/* Get rid of reference to old control tty */
 		if (vpold)
-			vrele(vpold);
+			devfs_ctty_unref(vpold);
 	}
 	return (error);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202104100602.13A625Cj015183>