From owner-freebsd-ports@freebsd.org Tue Nov 24 09:06:41 2020 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 99D9747E1EC for ; Tue, 24 Nov 2020 09:06:41 +0000 (UTC) (envelope-from yuripv@yuripv.dev) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4CgJ6l4JDMz4SWb; Tue, 24 Nov 2020 09:06:39 +0000 (UTC) (envelope-from yuripv@yuripv.dev) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 095FD580684; Tue, 24 Nov 2020 04:06:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 24 Nov 2020 04:06:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yuripv.dev; h= subject:to:references:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm1; bh=t mSwOwjvhScUUZ/NcFk2XLLJC8J6o9HYwTLzF8o7d+g=; b=W3YXpC5nm2IqYjubW EP4zNeYFMBynpNns1cj6UXDrALyPUQAZFbyhV0thjkK6jdyaWYeBBp1CQe6tIwn0 EE4rCQCuqUNHQmpE84Za7z82TN1mi9zVREDA3nqKdia8hDZmuMBB2zeH7SnKcXgJ Rv60P4BGWtQObyscR30bYvmwJt3vQ0krxtKncmQeMG/5IKd7OY7dNnN2HunFAziq pJ+2iIWc3Oi2jbfpOIWfNzop+yH6WvWKkPkS77hFyb2cu3NobxMOqnw5C1wUe6KW bpZzw9+IK0KriW9n21iYkAn6x1dOGcQeXO3LZ+EmieFLQXEo9+QgpVWc1XtwOwHu lQn4g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=tmSwOwjvhScUUZ/NcFk2XLLJC8J6o9HYwTLzF8o7d +g=; b=B0D2Y661nnOppE74plmpEyxIU0CW2DGoOoOMaYVUvzV/3j6j7EGJepy1F Adiiv2ldtduL6C24RhR8v+at0RdD7eNl9yFJUaMNUK9zgU/N05fzN7URv6EgzuaQ KylvTeKqcG7HOhpf2Nyk3pqmKEyqYc2RoQptwJ06N8Ecufo6hn2fvPW6UIAT/J3u GXfGHRCOZO8O1xfaGy0J4kDvxCLyTLHcVXlRpxf9w6Fy66TaaluvDmRy6cmEzXJo tH58xdf0jdotKQ3DOLwSLgXLDwHNJfVC06e7p01k9rWagdNOVIFdF1fIOFUixNAu onZRkXlLonm+fOVDsQKUDprUGSkUA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudegkecutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecunecujfgurhepuffvfhfhkffffgggjggtgfesthekredttd efjeenucfhrhhomhepjghurhhiucfrrghnkhhovhcuoeihuhhrihhpvheshihurhhiphhv rdguvghvqeenucggtffrrghtthgvrhhnpeevfeevgfetgfeukeefjeduueekffejuefgie etteeuledvtdethfelhedvjeetveenucffohhmrghinhepfhhrvggvsghsugdrohhrghen ucfkphepledurddvgedtrdduvdegrdduheejnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhephihurhhiphhvseihuhhrihhpvhdruggvvh X-ME-Proxy: Received: from [192.168.1.6] (unknown [91.240.124.157]) by mail.messagingengine.com (Postfix) with ESMTPA id 39FDF3064AB3; Tue, 24 Nov 2020 04:06:38 -0500 (EST) Subject: Re: Portlint complains about %%FOO%% in PLIST_FILES To: rhurlin@FreeBSD.org, freebsd-ports@FreeBSD.org References: <50337e9b-ab50-6877-a5a6-213006f2195e@gwdg.de> From: Yuri Pankov Message-ID: <988ea1b1-fb58-55b9-43ff-6086e09f5894@yuripv.dev> Date: Tue, 24 Nov 2020 12:06:36 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <50337e9b-ab50-6877-a5a6-213006f2195e@gwdg.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4CgJ6l4JDMz4SWb X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yuripv.dev header.s=fm1 header.b=W3YXpC5n; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=B0D2Y661; dmarc=none; spf=pass (mx1.freebsd.org: domain of yuripv@yuripv.dev designates 66.111.4.224 as permitted sender) smtp.mailfrom=yuripv@yuripv.dev X-Spamd-Result: default: False [-3.60 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[yuripv.dev:s=fm1,messagingengine.com:s=fm1]; FREEFALL_USER(0.00)[yuripv]; FROM_HAS_DN(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[66.111.4.224:from]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:66.111.4.224]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[yuripv.dev]; SPAMHAUS_ZRD(0.00)[66.111.4.224:from:127.0.2.255]; RCVD_COUNT_THREE(0.00)[4]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; DKIM_TRACE(0.00)[yuripv.dev:+,messagingengine.com:+]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:11403, ipnet:66.111.4.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; MAILMAN_DEST(0.00)[freebsd-ports]; RCVD_IN_DNSWL_LOW(-0.10)[66.111.4.224:from] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Nov 2020 09:06:41 -0000 Rainer Hurling wrote: > Yesterday I committed net/hblock [r556099] after changing the patch to > PLIST_FILES (instead of pkg-plist with only two files) against the > suggestion of the submitter.The line in question is: > > PLIST_FILES=bin/${PORTNAME} %%MANPAGES%%man/man1/hblock.1.gz > > > I made this change because it allows the port to build and install > correctly in all combinations of OPTIONS. > > With the use of %%MANPAGES%%% in PLIST_FILES one can selectively enable > and disable the building of manpages. > > The maintainer of net/hblock informs me about a problem with using > %%MANPAGES%% in PLIST_FILES. I don't know why I did not notice the > message from 'portlint -AC' before: > > FATAL: PLIST_FILES: files cannot contain %%FOO%% variables.  Use make > variables and logic instead > > > Is it possibly correct to use %%MANPAGES%% in PLIST_FILES and only > portlint can't handle it? > > Is there an alternative to switching back to pkg-plist file? > > > Thanks in advance for clarification and maybe a suggestion for correct > usage. See 5.13.3.11 in https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html, i.e. use MANPAGES_PLIST_FILES=. See x11/swaybg/Makefile for example.