From owner-svn-src-head@freebsd.org Mon Jun 4 15:32:03 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E2C9AFEDC2C; Mon, 4 Jun 2018 15:32:02 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4F7AF6D92F; Mon, 4 Jun 2018 15:32:02 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w54FW0Ts096404; Mon, 4 Jun 2018 08:32:00 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w54FW0hl096403; Mon, 4 Jun 2018 08:32:00 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201806041532.w54FW0hl096403@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r334609 - head/usr.sbin/pmc In-Reply-To: To: Matt Joras Date: Mon, 4 Jun 2018 08:32:00 -0700 (PDT) CC: rgrimes@freebsd.org, Matt Macy , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jun 2018 15:32:03 -0000 [ Charset UTF-8 unsupported, converting... ] > On Mon, Jun 4, 2018 at 8:18 AM, Rodney W. Grimes > wrote: > > [ Charset UTF-8 unsupported, converting... ] > >> Author: mmacy > >> Date: Mon Jun 4 06:30:35 2018 > >> New Revision: 334609 > >> URL: https://svnweb.freebsd.org/changeset/base/334609 > >> > >> Log: > >> pmc filter: avoid spurious gcc uninitialized warning > > > > Is it truely uninitialzized, or are you silencing a bogus warning, > > this commit and the code does not make that clear, and that should > > be made clear. > I didn't check the code, but given he said "spurious", I don't think > there's much ambiguity. So your silencing a compiler warning without even figuring out if it is true or not. Please do not do that. That is not helpful to the code base. If it is a bogus warning, the code needs marked as such. If it is a valid warning, then what you did is the proper solution. > Matt > > > > > Thanks, > > Rod > >> > >> Modified: > >> head/usr.sbin/pmc/cmd_pmc_filter.c > >> > >> Modified: head/usr.sbin/pmc/cmd_pmc_filter.c > >> ============================================================================== > >> --- head/usr.sbin/pmc/cmd_pmc_filter.c Mon Jun 4 05:55:40 2018 (r334608) > >> +++ head/usr.sbin/pmc/cmd_pmc_filter.c Mon Jun 4 06:30:35 2018 (r334609) > >> @@ -145,7 +145,7 @@ pmc_filter_handler(uint32_t *lwplist, int lwpcount, ui > >> if ((ps = pmclog_open(infd)) == NULL) > >> errx(EX_OSERR, "ERROR: Cannot allocate pmclog parse state: %s\n", strerror(errno)); > >> > >> - pmccount = 0; > >> + eventcount = pmccount = 0; > >> while (pmclog_read(ps, &ev) == 0) { > >> if (ev.pl_type == PMCLOG_TYPE_INITIALIZE) > >> memcpy(cpuid, ev.pl_u.pl_i.pl_cpuid, PMC_CPUID_LEN); > >> > >> > > > > -- > > Rod Grimes rgrimes@freebsd.org > > > > -- Rod Grimes rgrimes@freebsd.org