From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Aug 18 17:30:01 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 69824106564A for ; Mon, 18 Aug 2008 17:30:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 3DC758FC1A for ; Mon, 18 Aug 2008 17:30:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m7IHU1ap018274 for ; Mon, 18 Aug 2008 17:30:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m7IHU1jg018273; Mon, 18 Aug 2008 17:30:01 GMT (envelope-from gnats) Resent-Date: Mon, 18 Aug 2008 17:30:01 GMT Resent-Message-Id: <200808181730.m7IHU1jg018273@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Boris Samorodov Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 715D2106564A for ; Mon, 18 Aug 2008 17:24:37 +0000 (UTC) (envelope-from bsam@bb.ipt.ru) Received: from bb.ipt.ru (bb.ipt.ru [194.62.233.89]) by mx1.freebsd.org (Postfix) with ESMTP id C28A78FC37 for ; Mon, 18 Aug 2008 17:24:36 +0000 (UTC) (envelope-from bsam@bb.ipt.ru) Received: from bb.ipt.ru (localhost [127.0.0.1]) by bb.ipt.ru (8.14.2/8.14.2) with ESMTP id m7IH2wL7097505 for ; Mon, 18 Aug 2008 21:02:58 +0400 (MSD) (envelope-from bsam@bb.ipt.ru) Received: (from bsam@localhost) by bb.ipt.ru (8.14.2/8.14.2/Submit) id m7IH2wr9097504; Mon, 18 Aug 2008 21:02:58 +0400 (MSD) (envelope-from bsam) Message-Id: <200808181702.m7IH2wr9097504@bb.ipt.ru> Date: Mon, 18 Aug 2008 21:02:58 +0400 (MSD) From: Boris Samorodov To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/126632: [patch] sysutils/bsdstats: should not delete shared (i.e. periodic) directories at deinstall X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Boris Samorodov List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Aug 2008 17:30:01 -0000 >Number: 126632 >Category: ports >Synopsis: [patch] sysutils/bsdstats: should not delete shared (i.e. periodic) directories at deinstall >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Mon Aug 18 17:30:00 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Boris Samorodov >Release: FreeBSD 7.0-STABLE i386 >Organization: InPharmtech, Co. >Environment: System: FreeBSD bb.ipt.ru 7.0-STABLE FreeBSD 7.0-STABLE #0: Wed Aug 13 19:20:01 MSD 2008 root@bb.ipt.ru:/usr/obj/usr/src/sys/BB i386 >Description: Sorry, but an idea to reduce a ports tree by one file happend to be wrong. At least for this port. ;-) The port tries to remove /usr/local/etc/periodic/daily and /usr/local/etc/periodic directories but they are commonly used by other ports, i.e. postgresql. ;-) And I'm sure some port may use periodic/monthly directory as well. So lets _try_ to remove those directories upon deinstall. >How-To-Repeat: Install postgresql-server-8, install bsdstats and then try to deinstall bsdstats: bb# pkg_delete /var/db/pkg/bsdstats-5.4_1 pkg_delete: unable to completely remove directory '/usr/local/etc/periodic' pkg_delete: couldn't entirely delete package (perhaps the packing list is incorrectly specified?) This is due to: bb# pkg_info -W /usr/local/etc/periodic/daily/502.pgsql /usr/local/etc/periodic/daily/502.pgsql was installed by package postgresql-server-8.1.10_2 >Fix: Note to a committer: a new file (pkg-plist) is created. --- bsdstats.diff begins here --- Index: Makefile =================================================================== RCS file: /home/pcvs/ports/sysutils/bsdstats/Makefile,v retrieving revision 1.55 diff -u -r1.55 Makefile --- Makefile 20 Dec 2007 04:39:11 -0000 1.55 +++ Makefile 18 Aug 2008 16:50:17 -0000 @@ -7,7 +7,7 @@ PORTNAME= bsdstats PORTVERSION= 5.4 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= sysutils DISTFILES= @@ -21,9 +21,6 @@ .endif NO_BUILD= yes -PLIST_FILES= etc/periodic/monthly/300.statistics etc/rc.d/bsdstats.sh -PLIST_DIRS= etc/periodic/monthly \ - etc/periodic do-install: ${MKDIR} ${LOCALBASE}/etc/periodic/monthly Index: pkg-plist =================================================================== RCS file: pkg-plist diff -N pkg-plist --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ pkg-plist 18 Aug 2008 16:50:17 -0000 @@ -0,0 +1,4 @@ +etc/periodic/monthly/300.statistics +etc/rc.d/bsdstats.sh +@dirrmtry etc/periodic/monthly +@dirrmtry etc/periodic --- bsdstats.diff ends here --- WBR -- bsam >Release-Note: >Audit-Trail: >Unformatted: