From owner-freebsd-toolchain@freebsd.org Sun Feb 14 19:21:59 2016 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D7C6EAA8203 for ; Sun, 14 Feb 2016 19:21:59 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: from asp.reflexion.net (outbound-mail-211-153.reflexion.net [208.70.211.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8DF6D1F13 for ; Sun, 14 Feb 2016 19:21:59 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: (qmail 18469 invoked from network); 14 Feb 2016 19:22:06 -0000 Received: from unknown (HELO mail-cs-01.app.dca.reflexion.local) (10.81.19.1) by 0 (rfx-qmail) with SMTP; 14 Feb 2016 19:22:06 -0000 Received: by mail-cs-01.app.dca.reflexion.local (Reflexion email security v7.80.0) with SMTP; Sun, 14 Feb 2016 14:22:01 -0500 (EST) Received: (qmail 16495 invoked from network); 14 Feb 2016 19:22:01 -0000 Received: from unknown (HELO iron2.pdx.net) (69.64.224.71) by 0 (rfx-qmail) with SMTP; 14 Feb 2016 19:22:01 -0000 X-No-Relay: not in my network X-No-Relay: not in my network Received: from [192.168.1.8] (c-76-115-7-162.hsd1.or.comcast.net [76.115.7.162]) by iron2.pdx.net (Postfix) with ESMTPSA id 2FDEE1C43D8; Sun, 14 Feb 2016 11:21:48 -0800 (PST) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Subject: /usr/src/Makefile.inc1 vs. buildworld finding include files: a problem for some contexts? Message-Id: Date: Sun, 14 Feb 2016 11:21:50 -0800 To: FreeBSD Toolchain , FreeBSD PowerPC ML Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) X-Mailer: Apple Mail (2.2104) X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Feb 2016 19:22:00 -0000 Is buildworld supposed to use /usr/include's area for finding files by = default? (I'm not talking of ${WORLDTMP}/usr/include but of just = /usr/include.) It does use /usr/include's area for some contexts: self-hosted builds = without a special XCC full path (e.g., an implicit TARGET_ARCH=3Dpowerpc = on a powerpc host using gcc 4.2.1 without an explicit XCC assignment = that also directs it to gcc 4.2.1 via a full path). /usr/src/Makefile.inc1 has the following sort of logic: > .if ${XCC:N${CCACHE_BIN}:M/*} . . . > .if defined(X_COMPILER_TYPE) && ${X_COMPILER_TYPE} =3D=3D gcc > XCFLAGS+=3D -isystem ${WORLDTMP}/usr/include = -L${WORLDTMP}/usr/lib > XCXXFLAGS+=3D -I${WORLDTMP}/usr/include/c++/v1 -std=3Dgnu++11 = -L${WORLDTMP}/../lib/libc++ . . . > .else . . . > .endif > XCFLAGS+=3D --sysroot=3D${WORLDTMP} ${BFLAGS} > XCXXFLAGS+=3D --sysroot=3D${WORLDTMP} ${BFLAGS} > .else > .if defined(CROSS_BINUTILS_PREFIX) && exists(${CROSS_BINUTILS_PREFIX}) > BFLAGS+=3D -B${CROSS_BINUTILS_PREFIX} > XCFLAGS+=3D ${BFLAGS} > XCXXFLAGS+=3D ${BFLAGS} > .endif > .endif # ${XCC:M/*} For contexts without the -isystem and/or --sysroot in XCFLAGS . . . Is it appropriate to submit bug reports for buildworld getting include = files from /usr/include instead of from ${WORLDTMP} or from /usr/src = areas? This tends to be noticed when something like the following. . . > # svnlite update -r295453 /usr/src > # env __MAKE_CONF=3D/root/src.configs/make.conf = SRC_ENV_CONF=3D/root/src.configs/src.conf.powerpc-gcc421.powerpc-host = MAKEOBJDIRPREFIX=3D/usr/obj/gcc421/powerpc.powerpc make -j 6 buildworld = buildkernel ends up with compile errors from using some older /usr/include header = files that are no longer sufficient to allow compilation. I recently had a couple of examples where the cc command in the script = output file for the failing compiles showed no -I , no -isystem , no = --sysroot , nothing that would have allowed it to even potentially avoid = /usr/include (old file) use. The Makefile*'s involved had no = CFLAGS+=3DSOMETHING_DIRECTING_INCLUDE_SEARCH . (Some types of header changes might not stop a build but might make the = build result wrong without much explicit notification. I'd prefer to = avoid such as well.) I expect that there are analogous points/questions for finding = libraries. =3D=3D=3D Mark Millard markmi at dsl-only.net