From nobody Wed Aug 16 18:20:57 2023 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RQxK92tQ4z4qx80 for ; Wed, 16 Aug 2023 18:21:01 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RQxK86Yh2z4Ldt for ; Wed, 16 Aug 2023 18:21:00 +0000 (UTC) (envelope-from jbeich@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692210060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8GEU76OEOECSKMn3YOzyLN1Tra3Rxrthx2Qap+HfRyE=; b=ecFi9TvW+vjVWCdaQw0ZpxKp9Jygzs8lLkbbUs6bR533VyHZxNmqnuyUn2F9nrjEfraVUY 04gUownpb8RYmgZW7b8k91+thDHmPcfKS2tomIrU2Q5RdkpYENQ9kLLAXWyUGfrA6bMH08 iKu0jdSEQNt3wP18gkrl1YTAjWcCdHxHYnGJ/IH0OCsMe4SRnJg0SxwWK8kDoPMQlXZeK/ /ddSYyPqxnPNt7tm0+R2feBQGdKUFH52SckvQoJUx3EZbN6mkIei8ryX/OGaMhAS67vNqy Cxm0vAZf1NEI+1WjsNmc389jSWVSVIKY6Hb09LUeNDOmQGwrcZxsvlBerY09Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692210060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8GEU76OEOECSKMn3YOzyLN1Tra3Rxrthx2Qap+HfRyE=; b=xiGENbg4cauIA4uVwnRmRe+vu6PVnU7YxkW/1ABDfEH4JQIzcjqt202vdzGG4nh7aKOuO4 yvIl4QzDCjmKIeJ2/blNpJWT8Gx51Cdt8DmugHc8HvJnwYBXQhCdUwqFRNS3Az5Pwju2fg sr5vfRNb3DStitVSpl8UU+YHUi9XSD4yAxHZjmj+SkmAuEki++iXs6x7Il5Qjr0Y4rSbZS sb9s9WODXPIoZVC44vrKy1h7vJsvWx5T2Bjzp2nU6Ge3bRMn5aMen9m9n3JZMRv44rjFjK lyvYCM7L37W9D3yTjBn3Bwqu4LwiwNwrlmT9PRPLpV8oC54wyT5HnzWHnCdkvA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1692210060; a=rsa-sha256; cv=none; b=Q2oFG3soy1Ci2b968+auXEfIGLb5fs7GhvECQJovVm7QCUWgspUx3ya9zmQVwUg781V5KO a7TRrq73+qmrf5Kgj3tq48pUupaFXgZAd5fCSZ0yrhsXXQNtszZSMLIMBOqLXAvA4WSB9d PsmNMqPTzLzW6OBftD4RQzUlHeSOYGB/lkIG5BPKYpXm0DOmbXHFlegEnQz+KBr/S/G/1J ms4YDX8T87NbM8qQmst2Py7eQJJK6YVCJpZ4tiDGXEJao2mPf6L27+XjtId48GVfsyf36A NnGcFKpnL1BfsJnhV7pBg3KbnQQTvW57ayKbmsdUA69uNIlbeo223IBOIF+AMQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: by freefall.freebsd.org (Postfix, from userid 1354) id C9ADA67ED; Wed, 16 Aug 2023 18:21:00 +0000 (UTC) From: Jan Beich To: ports@freebsd.org Subject: Re: plist-check not reporting orphaned files present in a @comment In-Reply-To: <5h3c6jbzs7y5k3hyimqn7jkyo3se3txvcywahpcffzc24hjew7@kx4mhnqq7gh4> (Felix Palmen's message of "Wed, 16 Aug 2023 20:13:25 +0200") References: <5h3c6jbzs7y5k3hyimqn7jkyo3se3txvcywahpcffzc24hjew7@kx4mhnqq7gh4> Date: Wed, 16 Aug 2023 20:20:57 +0200 Message-ID: <8raa-vofq-wny@FreeBSD.org> List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 Content-Type: text/plain Felix Palmen writes: > Hi all, > > I'm having unexpected trouble with plist-check. I have some custom > PLIST_SUB expanding to "@comment " based on ${ARCH} and found that > orphaned files from ${STAGEDIR} weren't properly reported. > > Then I tried to hardcode "@comment " in pkg-plist instead (to rule out > possible issues with expansion) and they *still* were not reported, > which seems very strange. Only when I removed the lines completely, > plist-check correctly reported the orphaned files. Looks intentional per https://cgit.freebsd.org/ports/commit/?id=e15449a9eff5 > - Fix showing files installed through unselected OPTIONS as orphans, > by considering "@comment file" to be ignored. [2] [...] > [2] This is a partial solution, we may still need a plist.ignore too. It > doesn't make much sense to add files in main pkg-plist we don't care about, > but maybe it does since you'll see and reconsider them being ignored > someday. @comment is used as all the OPTION PLIST_SUB deactivations use > @comment instead of something like @ignore.