From owner-freebsd-stable@freebsd.org Sun Sep 4 14:51:09 2016 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 10073A9D583; Sun, 4 Sep 2016 14:51:09 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8019B17C; Sun, 4 Sep 2016 14:51:08 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id u84Ep3N2066275 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sun, 4 Sep 2016 17:51:04 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua u84Ep3N2066275 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id u84Ep3m5066266; Sun, 4 Sep 2016 17:51:03 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 4 Sep 2016 17:51:03 +0300 From: Konstantin Belousov To: Andriy Gapon Cc: Frederic Chardon , freebsd-stable@FreeBSD.org, freebsd-current@FreeBSD.org Subject: Re: Regression with revision 303970 (was kern.proc.pathname failure while booting from zfs) Message-ID: <20160904145103.GD83214@kib.kiev.ua> References: <1aebfb2b-5df6-abe0-686f-b170fdaef510@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Sep 2016 14:51:09 -0000 On Sun, Sep 04, 2016 at 04:11:39PM +0300, Andriy Gapon wrote: > On 04/09/2016 11:24, Andriy Gapon wrote: > > On 27/08/2016 22:09, Frederic Chardon wrote: > >>> Anybody is able to reproduce this behavior or is it a local problem? > >> Reverting 303970 solves this issue. gcore and adb works again, and I > >> can start the vboxnet service. > >> I recreated my boot pool with no properties defined, just to be sure. > > > > I can not reproduce this issue here. > > I was not trying hard enough. I've just reproduced the problem using a > non-default normalization property. The issue is that 303970 disabled the use > of VFS name cache when any name "mangling" (normalization, case-insensitivity) > is enabled. And apparently I misunderstood how vop_stdvptocnp() works. So, > right now zfs_vptocnp() is broken when its argument is a non-directory vnode. > That fact is masked when the name cache is used and is exposed otherwise. It is only masked when name cache has an entry for the vnode. So sometimes vn_fullpath() should be broken even if no normalization is applied. OTOH, classic filesystems like UFS do not have any other means to translate non-directory inode to name and parent at all, except the namecache hint.