From owner-svn-src-head@FreeBSD.ORG Wed Mar 19 18:10:53 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DB01DF27; Wed, 19 Mar 2014 18:10:53 +0000 (UTC) Received: from mx1.stack.nl (relay02.stack.nl [IPv6:2001:610:1108:5010::104]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9EA19A26; Wed, 19 Mar 2014 18:10:53 +0000 (UTC) Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131]) by mx1.stack.nl (Postfix) with ESMTP id 79DC93592D9; Wed, 19 Mar 2014 19:10:51 +0100 (CET) Received: by snail.stack.nl (Postfix, from userid 1677) id 5742D28497; Wed, 19 Mar 2014 19:10:51 +0100 (CET) Date: Wed, 19 Mar 2014 19:10:51 +0100 From: Jilles Tjoelker To: Attilio Rao Subject: Re: svn commit: r263318 - in head: sys/compat/freebsd32 sys/kern sys/sys usr.bin/truss Message-ID: <20140319181051.GA86549@stack.nl> References: <201403182132.s2ILW33e060898@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201403182132.s2ILW33e060898@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Mar 2014 18:10:53 -0000 On Tue, Mar 18, 2014 at 09:32:03PM +0000, Attilio Rao wrote: > Author: attilio > Date: Tue Mar 18 21:32:03 2014 > New Revision: 263318 > URL: http://svnweb.freebsd.org/changeset/base/263318 > Log: > Remove dead code from umtx support: > - Retire long time unused (basically always unused) sys__umtx_lock() > and sys__umtx_unlock() syscalls > - struct umtx and their supporting definitions > - UMUTEX_ERROR_CHECK flag > - Retire UMTX_OP_LOCK/UMTX_OP_UNLOCK from _umtx_op() syscall > __FreeBSD_version is not bumped yet because it is expected that further > breakages to the umtx interface will follow up in the next days. > However there will be a final bump when necessary. > Sponsored by: EMC / Isilon storage division > Reviewed by: jhb > [snip] > Modified: head/sys/sys/umtx.h > ============================================================================== > --- head/sys/sys/umtx.h Tue Mar 18 20:14:13 2014 (r263317) > +++ head/sys/sys/umtx.h Tue Mar 18 21:32:03 2014 (r263318) > [snip] > -static __inline int > -umtx_wait(u_long *p, long val, const struct timespec *timeout) > -{ > - if (_umtx_op(p, UMTX_OP_WAIT, val, 0, > - __DECONST(void *, timeout)) == -1) > - return (errno); > - return (0); > -} > - > -/* Wake threads waiting on a user address. */ > -static __inline int > -umtx_wake(u_long *p, int nr_wakeup) > -{ > - if (_umtx_op(p, UMTX_OP_WAKE, nr_wakeup, 0, 0) == -1) > - return (errno); > - return (0); > -} > - These two do not use struct umtx, are not obsolete and are used by some ports, such as lang/sbcl with certain options. They are similar to the Linux futex system call. The relatively recent libxshmfence uses the underlying umtx_op directly, mainly because there is no static inline function for UMTX_OP_WAIT_UINT. -- Jilles Tjoelker