Date: Mon, 26 Sep 2005 08:42:40 +0200 From: Roman Neuhauser <neuhauser@sigpipe.cz> To: "Michael C. Shultz" <ringworm01@gmail.com> Cc: freebsd-ports@freebsd.org Subject: Re: ports/Mk/bsd.port.mk,v 1.517 2005/09/15 12:24:33 question Message-ID: <20050926064240.GA1116@isis.sigpipe.cz> In-Reply-To: <200509251637.44134.ringworm01@gmail.com> References: <200509251559.53576.ringworm01@gmail.com> <1127691447.3077.8.camel@ikaros.oook.cz> <200509251637.44134.ringworm01@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
# ringworm01@gmail.com / 2005-09-25 16:37:42 -0700:
> On Sunday 25 September 2005 16:37, Pav Lucistnik wrote:
> > Michael C. Shultz píše v ne 25. 09. 2005 v 15:59 -0700:
> > > Is it possible/desirable to modify bsd.port.mk so that
> > > ports marked IGNORE or BROKEN exit with an error
> > > code, like "make check-conflicts" does if there is a conflict?
> > >
> > > Right now there is a problem with sysutils/portmanager
> > > not properly handling ports marked BROKEN because
> > > make seems to exit with no error. I could add parsing
> > > Makefiles for the term "BROKEN" to portmanager, but that
> > > seems a shame, because untill now portmanager has never
> > > needed to snoop the insides of Makefiles.
> >
> > what about running "make -V BROKEN" ?
>
> That still seems to return no error code.
You need to check the *output*. It it's not empty, the port is
marked broken.
> I'm no perl programmer, but I tried adding this to
> bsd.port.mk just below check-conflicts:
Makefiles are not written in Perl.
> It works for my purposes, but I've never tried submitting anything on the
> ports infrastructure, do you think this would fly?
It wouldn't, because it would break lots of code.
> It sure would make my life easier, because all I would have to do is
> test "make check-broken" target.
make -V BROKEN will do the same. Just test whether there was any
output.
--
How many Vietnam vets does it take to screw in a light bulb?
You don't know, man. You don't KNOW.
Cause you weren't THERE. http://bash.org/?255991
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050926064240.GA1116>