From owner-freebsd-ports Tue Nov 12 5:45:55 2002 Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5FD8F37B401 for ; Tue, 12 Nov 2002 05:45:54 -0800 (PST) Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by mx1.FreeBSD.org (Postfix) with ESMTP id B1D3D43E3B for ; Tue, 12 Nov 2002 05:45:53 -0800 (PST) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.12.1/8.12.1) with ESMTP id gACDjkXL142958; Tue, 12 Nov 2002 08:45:46 -0500 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20021112022737.GA75157@rot13.obsecurity.org> References: <20021112022737.GA75157@rot13.obsecurity.org> Date: Tue, 12 Nov 2002 08:45:45 -0500 To: Kris Kennaway From: Garance A Drosihn Subject: Re: Thinking about PORTCOMMENTS Cc: freebsd-ports@FreeBSD.ORG Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: MIMEDefang 2.3 (www dot roaringpenguin dot com slash mimedefang) Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org At 6:27 PM -0800 11/11/02, Kris Kennaway wrote: >On Mon, Nov 11, 2002, Garance A Drosihn wrote: > >> Is the value of the proposed PORTCOMMENT value actually used in >> any make-targets? Or is it just read by some program to generate >> HTML pages? (...this is the part that I should have investigated >> more...). > >Yes, it's used in several make targets and therefore needs to be >readable by make. Well, I still have to apologize that I have not had the time to look at this in detail, but I skimmed through the update that Eric Melville had posted to see just how the value is used. It looks like the variable is simply copied into a file via: ${MAKE} -V PORTCOMMENT > ${WRKDIR}/comment and then that file is used. My guess is that it should be just as easy to skim the Makefile for the "fake-xml" setting, as it is to recursively call 'make' and process several hundred lines of make files and .included make files just to get the value of one variable. Am I right in assuming the only value of that variable that matters is the one in the ports own Makefile? (ie, that it would not be set via some .included file). And is the goal simply to remove the "pkg-comment" file? Or are there greater ideas involved, such as making the comment include values of other 'make' variables? And now for the part where I almost look more helpful instead of merely annoying: If my above assumptions are right, should I try to implement something which does what I'm talking about with these fake-xml settings? I could probably come up with something this weekend, or at least work long enough at that if I have no success I will shut up about it for awhile... -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message