From owner-freebsd-testing@FreeBSD.ORG Thu Mar 20 23:44:54 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 385218A3 for ; Thu, 20 Mar 2014 23:44:54 +0000 (UTC) Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com [209.85.216.181]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E5CD4792 for ; Thu, 20 Mar 2014 23:44:53 +0000 (UTC) Received: by mail-qc0-f181.google.com with SMTP id e9so1947997qcy.40 for ; Thu, 20 Mar 2014 16:44:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=cHUgYbj0vPl9i0wkAbzjD8ZjzLlClc2ovfPr4QE71co=; b=A5t+mBZFIOyW75pPEG/yGy6yGPkED1gdddf6kFsf5YkjFIxq/CRS5kTzLt56+k6ISl 5Urkl741cIcxZOwkfwBuL8uLuwZkj4MPnLXJekaWhymVM5peuq9+wlP3O9duIk6O5J0n XFnI83J3rwi7Ap1+K1RQlP4vzKx0mhyrPgHaV4GVEcyOIhuyO+adK8j06JtbkbwTMBjI 7tVIwq+Hsx9yhy8viKnslDr3IPWCCHn3wLRCpg+B5UdjlkHLqDmOH5I85MfkIRiEsYZg jxg2ueCUwgH3q5zFFiUl1W9VdNeudwlPBQXCLHpnocqZH8/NmhFzEcoJ/8Fex5Kn2v1y khmA== X-Gm-Message-State: ALoCoQnbt03yGUDHM0Boale62x2tDQlRWiLFGab/091g6i1AIGJZsq0qP2SJvRvlByc7Qh/9sUBE X-Received: by 10.224.119.141 with SMTP id z13mr52453972qaq.48.1395358609664; Thu, 20 Mar 2014 16:36:49 -0700 (PDT) MIME-Version: 1.0 Sender: jmmv@meroh.net Received: by 10.96.83.102 with HTTP; Thu, 20 Mar 2014 16:36:29 -0700 (PDT) X-Originating-IP: [1.242.225.82] In-Reply-To: References: <6BADC2BD-3C99-44F7-B6FB-6139AB8752D9@gmail.com> From: Julio Merino Date: Fri, 21 Mar 2014 08:36:29 +0900 X-Google-Sender-Auth: dq15IpX0plQjsDHy9erzqAq9vk8 Message-ID: Subject: Re: ATF config variables for FreeBSD tests To: Alan Somers Content-Type: text/plain; charset=ISO-8859-1 Cc: "freebsd-testing@freebsd.org" , "Kenneth D. Merry" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Mar 2014 23:44:54 -0000 On Tue, Mar 18, 2014 at 12:14 AM, Alan Somers wrote: > On Sun, Mar 16, 2014 at 10:53 AM, Garrett Cooper wrote: >> /usr/tests/libexec seems logical.. > > But that's where tests for the stuff in /libexec go. If anything, I > think /usr/libexec/tests would be more appropriate. Unfortunately, > such files would share the same source location as the tests for the > stuff in /libexec. But I think it's preferable to have a confusing > source layout to a confusing installed layout. Indeed. But if this is shared supporting code, there is no reason for it to live under /usr/tests. After all, the ATF libraries are not installed inside /usr/tests and do not live in src/tests/! For C, we'd just have a libfreebsd_tests.so or similar under /usr/lib/private and put the source under src/lib/ (and its tests --of course!-- under /usr/tests/lib/private/libfreebsd_tests/). For shell, it depends on how the "libraries" look like. One option is to have some installed .sh files that get sourced at runtime within the script; the other is to just concatenate the helper code to the test programs at build time and not install the library. In the former case, we'd just install this under /usr/libexec/something; in the latter, there is nothing to install. (There is also the option that these shell libraries are actually separate binaries, of course, but then the libexec layout also applies.) And if we are concerned about the code looking like actual tests, you'd always use .subr instead of .sh for supporting code as is done in some other places (e.g. rc.subr).