From owner-svn-src-all@freebsd.org Wed Sep 2 01:31:31 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C2BC99C6CA6; Wed, 2 Sep 2015 01:31:31 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id AF4F2309; Wed, 2 Sep 2015 01:31:31 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id A83DB135D; Wed, 2 Sep 2015 01:31:31 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 67D461172C; Wed, 2 Sep 2015 01:31:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id 0xwAX5v8m4x2; Wed, 2 Sep 2015 01:31:29 +0000 (UTC) Subject: Re: svn commit: r284598 - head/share/mk DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com DE17811722 To: "Simon J. Gerraty" References: <201506191456.t5JEuPDU074336@svn.freebsd.org> <55B8268A.5030305@FreeBSD.org> <4974.1438488939@chaos> Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org From: Bryan Drewery Organization: FreeBSD Message-ID: <55E6516F.5000805@FreeBSD.org> Date: Tue, 1 Sep 2015 18:31:27 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <4974.1438488939@chaos> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Sep 2015 01:31:31 -0000 On 8/1/15 9:15 PM, Simon J. Gerraty wrote: > Bryan Drewery wrote: >>> > > head/share/mk/local.sys.mk >> > >> > I'm bothered by the amount of local.* files committed in the tree. I >> > expect, as a user and working in a downstream product, that a local.* >> > file is MINE, not FREEBSD. The pattern of using 'local' is quite common >> > as a *user* file. > Yes that's exactly the point. > local*mk (and src*) do not get installed in /usr/share/mk, yet the > inlcudes exist as points for you to customize the behavior. > >> > Why are these named as such? It seems they should just be 'src.' with >> > .sinclude hooks for actual local overrides. > local* are name as such since that's all that bsd* should know about. > Providing for local customization. My concern is that checked in 'local' files should not be changed by FreeBSD. I should not have to fight conflicts of _my customizations_ against _FreeBSD customizations (against bmake upstream)_. There is so much logic in these local.* files, they seem more aptly named 'freebsd.*' as they seem to be intended to be customizations for FreeBSD, rather than optional customizations for a developer or other downstream consumer of FreeBSD. -- Regards, Bryan Drewery