From owner-freebsd-scsi@FreeBSD.ORG Wed Mar 3 21:57:31 2010 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 88752106566B for ; Wed, 3 Mar 2010 21:57:31 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from qw-out-2122.google.com (qw-out-2122.google.com [74.125.92.24]) by mx1.freebsd.org (Postfix) with ESMTP id 3E7978FC1A for ; Wed, 3 Mar 2010 21:57:30 +0000 (UTC) Received: by qw-out-2122.google.com with SMTP id 8so355685qwh.7 for ; Wed, 03 Mar 2010 13:57:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type; bh=A55CZu6IGVMbR+OCH5bqweIqZ3tW1oglgFsUd3aNu4o=; b=REeqgiMbh7LrhKo36tspRTNBnSFlUudt3t7zhlWmUyqHTtE6Aa4HqDtf5BRccw1TiL uwYxGAi1RZZdXCKyZtVvL8LjmYyduXmOpWgHwTchYe9L0Jxuyfx0Fz5lkTOhGLUNtTsb e6I10rGhN9uJH8gbvzCzVPuzzf9rJ3cYZUQSk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=r6NXPK8i/fEXOpTRViGL8a/lsbYcTpclUye+EpZnls3p9KI65EtR10AEjKMOD7ksw0 /hmeWaKLKvXwhWk01EWf5nwsFm8R9FLjQHyoR+yR55CQIrMEoyDarutNBKTRoxUV+C7x dVY9Ar18Qfjsq/KRpl7T+PCvtmT8sTwN1sqQI= MIME-Version: 1.0 Sender: asmrookie@gmail.com Received: by 10.224.41.137 with SMTP id o9mr527762qae.136.1267653442016; Wed, 03 Mar 2010 13:57:22 -0800 (PST) In-Reply-To: <4B8EDAE8.3080401@feral.com> References: <3bbf2fe11002281655i61a5f0a0if3f381ad0c4a1ef8@mail.gmail.com> <3bbf2fe11003020724m14bebf74y9fa3906418b7cf11@mail.gmail.com> <4B8D3016.2070301@feral.com> <3bbf2fe11003031334g4591c1a3lc52dfb898f728ee2@mail.gmail.com> <20100303214424.GA53790@sandvine.com> <3bbf2fe11003031348q4c1fcccfxd19da32875b43f56@mail.gmail.com> <4B8EDAE8.3080401@feral.com> Date: Wed, 3 Mar 2010 22:57:21 +0100 X-Google-Sender-Auth: 356935db693c2104 Message-ID: <3bbf2fe11003031357o518d6028m8157d9110a9122f3@mail.gmail.com> From: Attilio Rao To: mj@feral.com Content-Type: text/plain; charset=UTF-8 Cc: freebsd-scsi@freebsd.org Subject: Re: How is supposed to be protected the units list? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Mar 2010 21:57:31 -0000 2010/3/3 Matthew Jacob : > On static review, the only code that makes me nervous are > ata_shutdown/da_shutdown. > Those are the only places where you hold that lock across an uncertain > interval. Please note that a def mutex is already held (the cam_periph_lock), so, unless LORs I'm not thinking about, I don't expect too much surprises for that codepath. Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein