From owner-freebsd-stable@freebsd.org  Tue May 30 16:22:14 2017
Return-Path: <owner-freebsd-stable@freebsd.org>
Delivered-To: freebsd-stable@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1A755B87025
 for <freebsd-stable@mailman.ysv.freebsd.org>;
 Tue, 30 May 2017 16:22:14 +0000 (UTC)
 (envelope-from petefrench@ingresso.co.uk)
Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3])
 by mx1.freebsd.org (Postfix) with ESMTP id F320C6AB6F
 for <freebsd-stable@freebsd.org>; Tue, 30 May 2017 16:22:13 +0000 (UTC)
 (envelope-from petefrench@ingresso.co.uk)
Received: by mailman.ysv.freebsd.org (Postfix)
 id F2538B87024; Tue, 30 May 2017 16:22:13 +0000 (UTC)
Delivered-To: stable@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id F1E3BB87023
 for <stable@mailman.ysv.freebsd.org>; Tue, 30 May 2017 16:22:13 +0000 (UTC)
 (envelope-from petefrench@ingresso.co.uk)
Received: from constantine.ingresso.co.uk (unknown [IPv6:2a02:b90:3002:411::3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 85D886AB6B;
 Tue, 30 May 2017 16:22:13 +0000 (UTC)
 (envelope-from petefrench@ingresso.co.uk)
Received: from dilbert.ingresso.co.uk ([2a02:b90:3002:411::6])
 by constantine.ingresso.co.uk with esmtpsa
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89 (FreeBSD))
 (envelope-from <petefrench@ingresso.co.uk>)
 id 1dFjuN-0007BR-3m; Tue, 30 May 2017 16:22:11 +0000
Received: from petefrench by dilbert.ingresso.co.uk with local (Exim 4.89
 (FreeBSD)) (envelope-from <petefrench@ingresso.co.uk>)
 id 1dFjuN-0000l0-0c; Tue, 30 May 2017 17:22:11 +0100
To: bapt@FreeBSD.org, petefrench@ingresso.co.uk
Subject: Re: 11.1-PRERELEASE, waagent crashes attaching reosurce disc in Azure
Cc: stable@freebsd.org
In-Reply-To: <e4fee006-a1a0-b25e-3835-ae9f857f171c@ingresso.co.uk>
Message-Id: <E1dFjuN-0000l0-0c@dilbert.ingresso.co.uk>
From: Pete French <petefrench@ingresso.co.uk>
Date: Tue, 30 May 2017 17:22:11 +0100
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-stable>, 
 <mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable/>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 May 2017 16:22:14 -0000

A bit more investigation on this and I think I found what the differece is
at least. waagent is using camcontrol periphlist 3:1:0 to find devices,
and this has chnaged from placing the discs before the pass
devices to afterwards. So on an earlier version I get this:

	root@joanna-may:/home/webadmin # camcontrol periphlist 3:1:0
	da1:  generation: 4 index: 1 status: MORE
	pass1:  generation: 4 index: 2 status: LAST

and on the box with the issue it does this:

	root@backup-db:/home/webadmin # camcontrol periphlist 3:1:0
	pass1:  generation: 4 index: 1 status: MORE
	da1:  generation: 4 index: 2 status: LAST

So that box finds 'pass1' as the device when it should be finding 'da1'
which leads to the error. I have a vague memory of seeing a commit for this
go past too.

On the other hand, the oython looks like it shuold handle this, as it
appears to try and detect which devices are disks from the output of
gpart list, which should not let it use pass1 as if it was a disc.

-pete.