From owner-freebsd-current Tue Sep 3 10:23:44 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C9C1337B400; Tue, 3 Sep 2002 10:23:41 -0700 (PDT) Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5B3F843E3B; Tue, 3 Sep 2002 10:23:41 -0700 (PDT) (envelope-from dillon@apollo.backplane.com) Received: from apollo.backplane.com (localhost [127.0.0.1]) by apollo.backplane.com (8.12.5/8.12.4) with ESMTP id g83HNcPQ043026; Tue, 3 Sep 2002 10:23:38 -0700 (PDT) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.12.5/8.12.4/Submit) id g83HNccd043025; Tue, 3 Sep 2002 10:23:38 -0700 (PDT) (envelope-from dillon) Date: Tue, 3 Sep 2002 10:23:38 -0700 (PDT) From: Matthew Dillon Message-Id: <200209031723.g83HNccd043025@apollo.backplane.com> To: Peter Wemm Cc: ticso@cicely.de, Alexander Kabaev , ticso@cicely5.cicely.de, des@FreeBSD.ORG, current@FreeBSD.ORG Subject: Re: alpha tinderbox failure - kernel is broken. References: <20020903163714.049602A7D6@canning.wemm.org> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG : :Yes, imgact_elf.c rev 1.121 is the culprit. Reverting that change solves :the problem. : :It should probably be backed out and un-MFC'ed. *definately* un-MFC'ed. : :Cheers, :-Peter :-- :Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com :"All of this is for nothing if we don't go to the stars" - JMS/B5 I have an alpha, let me try to reproduce this (it may take a while). The datasize limit is fairly straight forward, either the failure is for real or there is an accounting problem somewhere. What happens if you replace this check in imgact_elf.c with a printf of the conditional clauses instead of generating a failure? + if (data_size > + imgp->proc->p_rlimit[RLIMIT_DATA].rlim_cur || + text_size > maxtsiz || + data_size + text_size > + imgp->proc->p_rlimit[RLIMIT_VMEM].rlim_cur) { + error = ENOMEM; + goto fail; + } Does that unbreak it? That would tell us which clause is causing the failure. You can probably do this faster then I can build a new world and kernel for my alpha. -Matt Matthew Dillon To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message