From owner-svn-src-all@FreeBSD.ORG Mon Dec 1 16:31:09 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B8847A10; Mon, 1 Dec 2014 16:31:09 +0000 (UTC) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 7E9A16BF; Mon, 1 Dec 2014 16:31:09 +0000 (UTC) Received: from [100.93.87.91] (184.sub-70-197-13.myvzw.com [70.197.13.184]) by elvis.mu.org (Postfix) with ESMTPSA id 12619341F867; Mon, 1 Dec 2014 08:31:09 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r275136 - in head/sys: dev/e1000 dev/ixgbe kern sys From: Alfred Perlstein X-Mailer: iPhone Mail (12B436) In-Reply-To: <547C974A.9050302@selasky.org> Date: Mon, 1 Dec 2014 08:31:08 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <4CE4C10D-93B0-4E27-878D-34C0A7CF3C94@mu.org> References: <201411262019.sAQKJaw4043557@svn.freebsd.org> <39377603.10OyiSzjWY@ralph.baldwin.cx> <872C180A-6ADD-469F-A801-3728DF134EEC@mu.org> <547C88A9.1070007@selasky.org> <5E1B6CD4-BBA7-4AD0-9982-E981015AF138@mu.org> <547C8A9C.4080603@selasky.org> <547C8CA2.8040305@selasky.org> <547C8DEF.5020809@selasky.org> <547C974A.9050302@selasky.org> To: Hans Petter Selasky Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , Alfred Perlstein , "src-committers@freebsd.org" , John Baldwin X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Dec 2014 16:31:09 -0000 > On Dec 1, 2014, at 8:28 AM, Hans Petter Selasky wrote: >=20 >> On 12/01/14 16:56, Alfred Perlstein wrote: >>=20 >>=20 >>>> On Dec 1, 2014, at 7:49 AM, Hans Petter Selasky wrote= : >>>>=20 >>>>> On 12/01/14 16:45, Alfred Perlstein wrote: >>>>>=20 >>>>> Hi, >>>>>=20 >>>>> It is quite early, actually: >>>>>=20 >>>>> SYSINIT(sysctl, SI_SUB_KMEM, SI_ORDER_FIRST, sysctl_register_all, 0); >>>>>=20 >>>>> In some parts of the machine independent, MI, code you neee to keep th= e TUNABLE_FETCH'es, because its run before SI_SUB_KMEM ! >>>>=20 >>>> Then it will not work unless I move the global n_queues sysctl creation= into the driver's mod load function. >>>>=20 >>>> Is that ok? >>>=20 >>> Are you asking me? >>=20 >> In soviet russia no one is ever sure whom to ask for permission to procee= d. >>=20 >> (Also you have significant commits to the driver so it makes sense. ) >=20 > Ok, >=20 > You need to check "sys/sys/kernel.h" for the full init order and figure ou= t where exactly your driver code is running and make sure that is running af= ter the SYSCTL/TUNABLE gets init. Yes that is why it is being done by hand in the probe routine. I think prope= r thing might be a way to sort out how to get tunables to run at a driver lo= ad event? Is that possible? >=20 > --HPS >=20 >=20