From owner-freebsd-current@FreeBSD.ORG  Mon Feb 16 11:08:27 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2BB2C16A4CE
	for <freebsd-current@freebsd.org>;
	Mon, 16 Feb 2004 11:08:27 -0800 (PST)
Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu
	[128.208.78.105])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1773243D1D
	for <freebsd-current@freebsd.org>;
	Mon, 16 Feb 2004 11:08:27 -0800 (PST)
	(envelope-from sgk@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (localhost [127.0.0.1])
	i1GJ8QTA062530;	Mon, 16 Feb 2004 11:08:26 -0800 (PST)
	(envelope-from sgk@troutmask.apl.washington.edu)
Received: (from sgk@localhost)i1GJ8PEJ062529;
	Mon, 16 Feb 2004 11:08:25 -0800 (PST)	(envelope-from sgk)
Date: Mon, 16 Feb 2004 11:08:25 -0800
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Maxim Konovalov <maxim@macomnet.ru>
Message-ID: <20040216190825.GA62505@troutmask.apl.washington.edu>
References: <200402141934.32797.msch@snafu.de>
	<20040215160713.U70835@news1.macomnet.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040215160713.U70835@news1.macomnet.ru>
User-Agent: Mutt/1.4.1i
cc: Matthias Schuendehuette <msch@snafu.de>
cc: freebsd-current@freebsd.org
Subject: Re: Panic with current kernel (ATA-related?)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Feb 2004 19:08:27 -0000

On Sun, Feb 15, 2004 at 04:10:48PM +0300, Maxim Konovalov wrote:
> 
> Index: ata-all.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/dev/ata/ata-all.c,v
> retrieving revision 1.203
> diff -u -r1.203 ata-all.c
> --- ata-all.c	30 Jan 2004 19:16:08 -0000	1.203
> +++ ata-all.c	14 Feb 2004 15:43:20 -0000
> @@ -567,7 +567,7 @@
>  	    while (retries-- > 0) {
>  		request->device = atadev;
>  		request->timeout = 5;
> -		request->retries = -1;
> +		request->retries = 3;
>  		request->u.ata.command = command;
>  		request->flags = (ATA_R_READ | ATA_R_IMMEDIATE);
>  		request->data = (caddr_t)atadev->param;
> %%%
> 

This patch fixes my mtrash_ctor panic.  For details, see

http://lists.freebsd.org/pipermail/freebsd-current/2004-February/020580.html

Please commit it.

-- 
Steve