From owner-freebsd-arm@FreeBSD.ORG  Thu Jun  5 05:54:29 2014
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id A1063FC5
 for <arm@freebsd.org>; Thu,  5 Jun 2014 05:54:29 +0000 (UTC)
Received: from mail.turbocat.net (mail.turbocat.net
 [IPv6:2a01:4f8:d16:4514::2])
 (using TLSv1.1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 6259920E1
 for <arm@freebsd.org>; Thu,  5 Jun 2014 05:54:29 +0000 (UTC)
Received: from laptop015.home.selasky.org
 (cm-176.74.213.204.customer.telag.net [176.74.213.204])
 (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id BE4C71FE02A;
 Thu,  5 Jun 2014 07:54:28 +0200 (CEST)
Message-ID: <53900636.30700@selasky.org>
Date: Thu, 05 Jun 2014 07:55:02 +0200
From: Hans Petter Selasky <hps@selasky.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.1.0
MIME-Version: 1.0
To: "Scott, Brian" <brian.scott4@det.nsw.edu.au>, 
 "'arm@freebsd.org'" <arm@freebsd.org>
Subject: Re: Changes to dwc_otg USB controller code (stable/10)
References: <7DB382CFB050654DBFF7A39B1F8056EB3321BE3F@WPEXCHMBSL1021.central.det.win>
 <538EF145.5020608@selasky.org> <538EF541.9050502@selasky.org>
 <7DB382CFB050654DBFF7A39B1F8056EB3321C1AB@WPEXCHMBSL1021.central.det.win>
In-Reply-To: <7DB382CFB050654DBFF7A39B1F8056EB3321C1AB@WPEXCHMBSL1021.central.det.win>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: "Porting FreeBSD to ARM processors." <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm/>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Jun 2014 05:54:29 -0000

On 06/05/14 06:41, Scott, Brian wrote:
> Hi,
>
> A few little problems with the compiler...
>
> /usr/src/sys/modules/usb/dwc_otg/../../../dev/usb/controller/dwc_otg.c:3692:21: error: assigning to 'struct usb_bus_methods *' from 'const struct usb_bus_methods *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
>          sc->sc_bus.methods = &dwc_otg_bus_methods;
>                             ^ ~~~~~~~~~~~~~~~~~~~~
> /usr/src/sys/modules/usb/dwc_otg/../../../dev/usb/controller/dwc_otg.c:4727:16: error: assigning to 'struct usb_pipe_methods *' from 'const struct usb_pipe_methods *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
>                          ep->methods = &dwc_otg_device_isoc_methods;
>                                      ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /usr/src/sys/modules/usb/dwc_otg/../../../dev/usb/controller/dwc_otg.c:4729:16: error: assigning to 'struct usb_pipe_methods *' from 'const struct usb_pipe_methods *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
>                          ep->methods = &dwc_otg_device_non_isoc_methods;
>                                      ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 3 errors generated.
>
> [I guessing I did this right: the changeset just listed the one file changed so I copied the file over to my stable/10 source tree and compiled. If there are other related things I need to track down then let me know]
>
> Brian

Hi,

That won't work. You need to patch the 10-stable sources:

fetch -o dwc_otg.diff 
"http://svnweb.freebsd.org/base/head/sys/dev/usb/controller/dwc_otg.c?r1=266833&r2=267044&view=patch"
cd /usr/src/sys
cat dwc_otg.diff | patch -p2

--HPS