From owner-svn-src-head@freebsd.org Sun Jan 14 20:16:59 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6A19CEB4B9D for ; Sun, 14 Jan 2018 20:16:59 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22b.google.com (mail-io0-x22b.google.com [IPv6:2607:f8b0:4001:c06::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 33FF86ADF7 for ; Sun, 14 Jan 2018 20:16:59 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22b.google.com with SMTP id l17so1175543ioc.3 for ; Sun, 14 Jan 2018 12:16:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=2N+B2UYEWt3g5b85oStlTs3skNINhhulxc3TyB7TWT4=; b=T16p0CowtZ1nXZU3ni+adtKkHusIsdMmqWYqit5umelJJrZU6UM/niX4YtYXmQPX/L +8yoJo8tigtWVjezMYitoSPjZlQRPKiOJFumhY8YKzOpq9BY3EXP1b6Mj1WO3+ikiG0a XCtT0UawAnalBxPDE40mEgAd76ZMf+0TpxPFMvEqH8KAxQ88whfLmBZnutI1YanSPgbX glf35Rj46hFD3jvMmCrH48UsP19VlB9VG2Gw/NXktaYYhkAs4oqiM02EJU8Uouu89ya+ h3cu8lS3IijSCIsdGWNyBSbKJtAhEm5TQCEqqUHNFBrCsUhAhIOJ8hH1Vb0K/Lb9KPDp 42Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=2N+B2UYEWt3g5b85oStlTs3skNINhhulxc3TyB7TWT4=; b=aeA7rk+BI9Poc8Uzspb6WSuTFPTx0W37I7DNuTPTZ9cN6WIVMMxvBP+tdGrRFxduvk Aw4f5yw2V9nlYZy9oPURAZEQzPCuRY15n28UhBW5zwab0Iwn5rb+MrekemPIYu1Jabnn VzEevi8Nq8xLGd9UoXzeYNBlWVxlnGtuGbc+UXD9Ow+yaDo3YFL4G61iA9l8Ikjj+d7a ycD+TVcTFzLLTAAy4ExPvJBUJXIYWj8IUzYuMqTKN0Exi3HFzHXUPmaLOHhvN/f81wvk mrtcy+I/z0qsd0ICnqxdw5pZ/S/T2W3b3fYEvFOHk2aH7O65t/jSq/d7vFm3uagzIEmk 3cCw== X-Gm-Message-State: AKGB3mJv7NmlNjXNjhHUemR5EbYsSg68OyB7FMDuiXaXsAWyKjn+HkEq t0ZsQuvt5XSoFufo7+vWvKH53JfqiWGsV9KBm6HTXQ== X-Google-Smtp-Source: ACJfBovafMnFOVVRSS2qcT5Y3Ghue7KFJ2Ni0Uu+iXxfsrLxDEKT2AhybB3y8UyuwtvgkISjnNU6Ij2DJkGhW2H7WxM= X-Received: by 10.107.180.151 with SMTP id d145mr29425717iof.136.1515961018371; Sun, 14 Jan 2018 12:16:58 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.199.131 with HTTP; Sun, 14 Jan 2018 12:16:57 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:a98c:bd66:bb3a:60ec] Received: by 10.79.199.131 with HTTP; Sun, 14 Jan 2018 12:16:57 -0800 (PST) In-Reply-To: <20180114171448.GB89171@raichu> References: <201801132230.w0DMUVmF081985@repo.freebsd.org> <7fe2a0bb-8592-75bc-6f58-cb77e2d6044c@FreeBSD.org> <20180114171448.GB89171@raichu> From: Warner Losh Date: Sun, 14 Jan 2018 13:16:57 -0700 X-Google-Sender-Auth: e0wFI8ncdI2xFQGosv1Jouj_Mzg Message-ID: Subject: Re: svn commit: r327949 - in head/sys/dev: aacraid advansys ath beri/virtio bnxt bwn ciss cxgbe/crypto esp fb gpio if_ndis iwi kbd liquidio liquidio/base mpr mps mpt mrsas mxge netmap nvme pst ral rp s... To: Mark Johnston Cc: Pedro Giffuni , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jan 2018 20:16:59 -0000 On Jan 14, 2018 10:15 AM, "Mark Johnston" wrote: On Sat, Jan 13, 2018 at 05:34:24PM -0500, Pedro Giffuni wrote: > > > On 01/13/18 17:30, Pedro F. Giffuni wrote: > > Author: pfg > > Date: Sat Jan 13 22:30:30 2018 > > New Revision: 327949 > > URL: https://svnweb.freebsd.org/changeset/base/327949 > > > > Log: > > dev: make some use of mallocarray(9). > > > > Focus on code where we are doing multiplications within malloc(9). None of > > these is likely to overflow, however the change is still useful as some > > static checkers can benefit from the allocation attributes we use for > > mallocarray. > > > > This initial sweep only covers malloc(9) calls with M_NOWAIT. No good > > reason but I started doing the changes before r327796 and at that time it > > was convenient to make sure the sorrounding code could handle NULL values. > > > For the record, this was part of > > https://reviews.freebsd.org/D13837 > > I didn't mention it in the commit log because I am not ready to close > the revision yet. Some developers have been using the "X-Differential revision:" tag in this case. I just list it per normal, but reopen the review if I need to. Warner