From owner-svn-src-head@freebsd.org Mon Nov 5 23:45:48 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
by mailman.ysv.freebsd.org (Postfix) with ESMTP id 42B2D110F830;
Mon, 5 Nov 2018 23:45:48 +0000 (UTC)
(envelope-from arichardson.kde@gmail.com)
Received: from mail-yw1-f48.google.com (mail-yw1-f48.google.com
[209.85.161.48])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(Client CN "smtp.gmail.com",
Issuer "Google Internet Authority G3" (verified OK))
by mx1.freebsd.org (Postfix) with ESMTPS id 9CF427B42B;
Mon, 5 Nov 2018 23:45:47 +0000 (UTC)
(envelope-from arichardson.kde@gmail.com)
Received: by mail-yw1-f48.google.com with SMTP id d126-v6so4429579ywa.5;
Mon, 05 Nov 2018 15:45:47 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=xolsq+ezWhP3m1J+ER6U2/qFiRD2cWEK79aR7Ft3eQQ=;
b=SClWuNDZG5dGxQ7jwOkU93rWND2aXPzuxlhUtBbllIvsRCyf+5nVBLJAwNtjSnhMN3
4TSotviZR8wxHr3eCglX5hgeDeq5x6LFAGo7pni7m0YPV3xK3oP4OqvWl7rsvIFuqgNd
Yr/Q8V6Pfp6Z84vK4TwUT+NHEgvp0QsbTedrOz8NbgB5PMXj9gBjJCZV8EOh5XNYfKHJ
yE8XGzE+75pVNG54rh2lVFa++e+M5qEsareUeEB2+3W5jpYfnyXRFo4lhisunUWXOrfd
jSEmt/RGvWsJ65WRCzOwp8zvFiCIOo9qgxrQhnyXH4v+A05xJz5WFyDcg4CFka7eotyN
hF0A==
X-Gm-Message-State: AGRZ1gKO98fNNb2iktaz9o3uZN52tutENwczxo3XAO44Fmc/Q9XXfwsM
CRR0J7ACUoQdTgqbJXIPI00Lmoyh7feMUw==
X-Google-Smtp-Source: AJdET5ccYQEEvpJ6MpSVTS0DrRtzZ+mtxwMO0Gn3U/tGg6KjHSwix8qArCUkWgHC3uNJ9PhRudTq3g==
X-Received: by 2002:a81:3404:: with SMTP id
b4-v6mr23503398ywa.410.1541459653608;
Mon, 05 Nov 2018 15:14:13 -0800 (PST)
Received: from mail-yw1-f49.google.com (mail-yw1-f49.google.com.
[209.85.161.49])
by smtp.gmail.com with ESMTPSA id i189-v6sm9639364ywb.23.2018.11.05.15.14.13
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Mon, 05 Nov 2018 15:14:13 -0800 (PST)
Received: by mail-yw1-f49.google.com with SMTP id v77-v6so4404713ywc.4;
Mon, 05 Nov 2018 15:14:13 -0800 (PST)
X-Received: by 2002:a81:417:: with SMTP id
23-v6mr21877960ywe.203.1541459653106;
Mon, 05 Nov 2018 15:14:13 -0800 (PST)
MIME-Version: 1.0
References: <201808231819.w7NIJAq5071940@repo.freebsd.org>
<a7768d1a-a59f-6a82-7085-48e8d62db1f9@FreeBSD.org>
In-Reply-To: <a7768d1a-a59f-6a82-7085-48e8d62db1f9@FreeBSD.org>
From: Alexander Richardson <arichardson@freebsd.org>
Date: Mon, 5 Nov 2018 23:14:01 +0000
X-Gmail-Original-Message-ID: <CA+Z_v8psoyk9stb91-PMOn4Pq4yoqu6=mOd+20b70V3cuv8VzA@mail.gmail.com>
Message-ID: <CA+Z_v8psoyk9stb91-PMOn4Pq4yoqu6=mOd+20b70V3cuv8VzA@mail.gmail.com>
Subject: Re: svn commit: r338268 - head
To: bdrewery@freebsd.org
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
svn-src-head@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-Rspamd-Queue-Id: 9CF427B42B
X-Spamd-Result: default: False [-3.98 / 200.00]; ARC_NA(0.00)[];
RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0];
FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4];
R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17];
TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain];
RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[freebsd.org];
TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.999,0];
RCVD_COUNT_THREE(0.00)[4];
RWL_MAILSPIKE_GOOD(0.00)[48.161.85.209.rep.mailspike.net : 127.0.0.18];
MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com];
NEURAL_HAM_SHORT(-0.96)[-0.963,0];
RCVD_IN_DNSWL_NONE(0.00)[48.161.85.209.list.dnswl.org : 127.0.5.0];
IP_SCORE(-1.00)[ipnet: 209.85.128.0/17(-3.61), asn: 15169(-1.35), country:
US(-0.07)];
FORGED_SENDER(0.30)[arichardson@freebsd.org,arichardsonkde@gmail.com];
R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com];
ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US];
TAGGED_FROM(0.00)[];
FROM_NEQ_ENVFROM(0.00)[arichardson@freebsd.org,arichardsonkde@gmail.com]
X-Rspamd-Server: mx1.freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
<svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Nov 2018 23:45:48 -0000
On Mon, 5 Nov 2018 at 23:03, Bryan Drewery <bdrewery@freebsd.org> wrote:
>
> On 8/23/2018 11:19 AM, Alex Richardson wrote:
> > Author: arichardson
> > Date: Thu Aug 23 18:19:10 2018
> > New Revision: 338268
> > URL: https://svnweb.freebsd.org/changeset/base/338268
> >
> > Log:
> > Fix non-FreeBSD host lib32 build for TARGET=amd64
> >
> > When building on non-FreeBSD systems we need to pass an explicit target
> > triple to clang otherwise it will attempt to build with the host triple.
> > This also has advantages when building on a FreeBSD host: we now tell
> > clang that we are targeting at least FreeBSD 12.0 instead of an older
> > version so it can enable newer features.
> >
> > Reviewed By: brooks (mentor)
> > Approved By: jhb (mentor)
> > Differential Revision: https://reviews.freebsd.org/D16842
> >
> > Modified:
> > head/Makefile.libcompat
> >
> > Modified: head/Makefile.libcompat
> > ==============================================================================
> > --- head/Makefile.libcompat Thu Aug 23 18:19:01 2018 (r338267)
> > +++ head/Makefile.libcompat Thu Aug 23 18:19:10 2018 (r338268)
> > @@ -14,6 +14,11 @@ LIB32CPUFLAGS= -march=i686 -mmmx -msse -msse2
> > .else
> > LIB32CPUFLAGS= -march=${TARGET_CPUTYPE}
> > .endif
> > +.if ${WANT_COMPILER_TYPE} == gcc || \
> > + (defined(X_COMPILER_TYPE) && ${X_COMPILER_TYPE} == gcc)
> > +.else
> > +LIB32CPUFLAGS+= -target x86_64-unknown-freebsd12.0
>
> This can be ${TARGET_TRIPLE}, no?
> It also seems like it should be in the LIBSOFT flags too; via
> LIBCOMPATCFLAGS.
Yes, that would be better. I didn't see that we already had a variable
with the target triple when I wrote this patch.
I can fix this tomorrow morning.
Alex
>
> > +.endif
> > LIB32CPUFLAGS+= -m32
> > LIB32WMAKEENV= MACHINE=i386 MACHINE_ARCH=i386 \
> > MACHINE_CPU="i686 mmx sse sse2"
> >
>
>
> --
> Regards,
> Bryan Drewery
>