From owner-p4-projects@FreeBSD.ORG  Tue Feb  5 18:21:12 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 364F016A468; Tue,  5 Feb 2008 18:21:12 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D6C9716A420;
	Tue,  5 Feb 2008 18:21:11 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 9B78613C455;
	Tue,  5 Feb 2008 18:21:11 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id AD52C47B86;
	Tue,  5 Feb 2008 13:21:10 -0500 (EST)
Date: Tue, 5 Feb 2008 18:21:10 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: John Birrell <jb@FreeBSD.org>
In-Reply-To: <200802050929.m159Tc2s024644@repoman.freebsd.org>
Message-ID: <20080205182026.D49855@fledge.watson.org>
References: <200802050929.m159Tc2s024644@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 134831 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Feb 2008 18:21:12 -0000

On Tue, 5 Feb 2008, John Birrell wrote:

> http://perforce.freebsd.org/chv.cgi?CH=134831
>
> Change 134831 by jb@jb_freebsd1 on 2008/02/05 09:29:08
>
> 	We define FOPEN_MAX as 20. What a joke.

I thought the comment was entertaining, apparently I'd never noticed that 
before:

/*
  * FOPEN_MAX is a minimum maximum, and is the number of streams that
  * stdio can provide without attempting to allocate further resources
  * (which could fail).  Do not use this for anything.
  */

Some piece of code clearly loses on this front..?

Robert N M Watson
Computer Laboratory
University of Cambridge

>
> Affected files ...
>
> .. //depot/projects/dtrace/src/contrib/one-true-awk/run.c#5 edit
>
> Differences ...
>
> ==== //depot/projects/dtrace/src/contrib/one-true-awk/run.c#5 (text+ko) ====
>
> @@ -63,6 +63,8 @@
> /* #ifndef RAND_MAX */
> /* #define RAND_MAX	32767 */	/* all that ansi guarantees */
> /* #endif */
> +#undef FOPEN_MAX
> +#define FOPEN_MAX	40
>
> jmp_buf env;
> extern	int	pairstack[];
>