From owner-svn-src-all@freebsd.org Mon Jan 22 17:44:03 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A4D1BECC47F; Mon, 22 Jan 2018 17:44:03 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-io0-f172.google.com (mail-io0-f172.google.com [209.85.223.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 74A091A71; Mon, 22 Jan 2018 17:44:02 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-io0-f172.google.com with SMTP id f34so10265285ioi.13; Mon, 22 Jan 2018 09:44:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Il8IB0g1YOtriJfkxf3Xj90IzkB3R2nxM8oLG0PSpio=; b=BXxFVRGqlP5Pipw1bjoC8kdZinVhZxv7M7OH4Seoavv+4WPwdry45Y1qr5gD/skpRZ 0K5+goNd/rD6iUCkwg9HyJxK5SOyxIYlOY48Ie8O0S7tRki9UKHRLhC83wZkL/7hRvno 7uxkujCuRi3KznpEE/kXJX+Kn3XBsVyip7p7ulekAT3NRG7HFJe2hZw8bVbIMRdjk3hV Djpc/+NisUO1n1ez5etj6FA+hItvLhF05cIMWB6V0jnfcUXcbrId4j4y81yn3N2ljLlN XzqKQYOJQ7mn3RilZKarpSHc1vbddCEyOg27Ap0Vqa4IvaGHBfRMnDexaIA7pXPBOHbD H9eA== X-Gm-Message-State: AKwxyteevMIOclNNy8Q8M9qtvq8GyE8KTOiq2O91z9S1pDlKrFJxLlTX 0SlBKinOEXsIpwUzJcqLJM+98+ZP X-Google-Smtp-Source: AH8x226Y/mZmNsV3la1GrtHGyrMlDK74XTAh++wEdI6q310ahfUTIc+GPwJSZYfpLghHFZVIv8LcEw== X-Received: by 10.107.83.12 with SMTP id h12mr8397891iob.277.1516643035763; Mon, 22 Jan 2018 09:43:55 -0800 (PST) Received: from mail-it0-f52.google.com (mail-it0-f52.google.com. [209.85.214.52]) by smtp.gmail.com with ESMTPSA id a202sm4016177ita.4.2018.01.22.09.43.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jan 2018 09:43:55 -0800 (PST) Received: by mail-it0-f52.google.com with SMTP id p124so10633107ite.1; Mon, 22 Jan 2018 09:43:55 -0800 (PST) X-Received: by 10.36.36.66 with SMTP id f63mr9445248ita.41.1516643034999; Mon, 22 Jan 2018 09:43:54 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.157.12 with HTTP; Mon, 22 Jan 2018 09:43:34 -0800 (PST) In-Reply-To: <20180122155307.GG55707@kib.kiev.ua> References: <201801220244.w0M2if3I083081@repo.freebsd.org> <20180122102639.GD55707@kib.kiev.ua> <20180122155307.GG55707@kib.kiev.ua> From: Kyle Evans Date: Mon, 22 Jan 2018 11:43:34 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r328240 - in head: etc/mtree lib lib/libc/regex lib/libc/tests/regex lib/libregex lib/libregex/tests share/mk To: Konstantin Belousov Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 17:44:03 -0000 On Mon, Jan 22, 2018 at 9:53 AM, Konstantin Belousov wrote: > On Mon, Jan 22, 2018 at 08:05:30AM -0600, Kyle Evans wrote: >> On Mon, Jan 22, 2018 at 4:26 AM, Konstantin Belousov >> wrote: >> > On Mon, Jan 22, 2018 at 02:44:41AM +0000, Kyle Evans wrote: >> >> Author: kevans >> >> Date: Mon Jan 22 02:44:41 2018 >> >> New Revision: 328240 >> >> URL: https://svnweb.freebsd.org/changeset/base/328240 >> >> >> >> Log: >> >> Add libregex, connect it to the build >> >> >> >> libregex is a regex(3) implementation intended to feature GNU extensions and >> >> any other non-POSIX compliant extensions that are deemed worthy. >> >> >> >> These extensions are separated out into a separate library for the sake of >> >> not cluttering up libc further with them as well as not deteriorating the >> >> speed (or lack thereof) of the libc implementation. >> >> >> >> libregex is implemented as a build of the libc implementation with LIBREGEX >> >> defined to distinguish this from a libc build. The reasons for >> >> implementation like this are two-fold: >> >> >> >> 1.) Maintenance- This reduces the overhead induced by adding yet another >> >> regex implementation to base. >> >> >> >> 2.) Ease of use- Flipping on GNU extensions will be as simple as linking >> >> against libregex, and POSIX-compliant compilations can be guaranteed with a >> >> REG_POSIX cflag that should be ignored by libc/regex and disables extensions >> >> in libregex. It is also easier to keep REG_POSIX sane and POSIX pure when >> >> implemented in this fashion. >> > You are doing very fragile and unmaintainable trick on all consumers >> > there. Your libregex.so exports the same symbols under the same version >> > as the libc does. In other words, we now provide two binary-incompatible >> > callable symbols, and selection of the symbol by the consumer depends on >> > the DT_NEEDED order and interposing. For instance, if some program loads >> > a module linked to your libregex, the program behaviour suddenly changes. >> > >> > Since the library provides incompatible implementation, it must use >> > different versions for the symbols, at least to save others time to >> > debug the mess. >> >> What's the best way that you see, going forward? >> >> I'm inclined to throw a Symbol.map into libregex using FBSD_1.1... >> these interfaces are otherwise stable stable within the two respective >> libraries, so I don't see that causing too much pain in the future >> because symbol version changes should be rare. > I do not think this is wise to create contention on the standard FreeBSD' > version namespace. > >> >> On the other hand, I could see wanting to use something more like >> FBSD_LIBREGEX_1.0 so that if the situation does come up one doesn't >> need to double-check that they're not colliding with the other >> implementation. > I like this more. We still have to carry that symbols with the current > behaviour forever, but at least they would no longer conflict with the > libc' symbols for dynamic linking. Right- that makes sense. Would you object to the following patch? The versioning was botched in the first place because of no VERSION_DEF. I've also dropped the FBSD_ prefix from my previous mention of it because there seems to be no good justification or precedent for it elsewhere in the tree that I've found. diff --git a/lib/libregex/Makefile b/lib/libregex/Makefile index eb6b0b64650..8ac496dd9f7 100644 --- a/lib/libregex/Makefile +++ b/lib/libregex/Makefile @@ -9,7 +9,8 @@ SHLIB_MINOR= 0 CFLAGS+= -DLIBREGEX LIBC_SRCTOP= ${.CURDIR:H}/libc -SYMBOL_MAPS= ${SYM_MAPS} +VERSION_DEF= ${.CURDIR}/Versions.def +SYMBOL_MAPS= ${.CURDIR}/Symbol.map WARNS?= 2 #HAS_TESTS= diff --git a/lib/libregex/Symbol.map b/lib/libregex/Symbol.map new file mode 100644 index 00000000000..1b77bd85aca --- /dev/null +++ b/lib/libregex/Symbol.map @@ -0,0 +1,10 @@ +/* + * $FreeBSD$ + */ + +LIBREGEX_1.0 { + regcomp; + regerror; + regexec; + regfree; +}; diff --git a/lib/libregex/Versions.def b/lib/libregex/Versions.def new file mode 100644 index 00000000000..b6c84200762 --- /dev/null +++ b/lib/libregex/Versions.def @@ -0,0 +1,5 @@ +# $FreeBSD$ + +LIBREGEX_1.0 { +}; +