Date: Tue, 20 Nov 2001 12:11:33 -0500 (EST) From: The Anarcat <anarcat@anarcat.dyndns.org> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/32139: [maintainer patch] update of audio/ecasound Message-ID: <20011120171133.C20FA20ADB@shall.anarcat.dyndns.org>
next in thread | raw e-mail | index | archive | help
>Number: 32139 >Category: ports >Synopsis: [maintainer patch] update of audio/ecasound >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Tue Nov 20 09:20:00 PST 2001 >Closed-Date: >Last-Modified: >Originator: The Anarcat >Release: FreeBSD 4.4-STABLE i386 >Organization: Nada, Inc. >Environment: System: FreeBSD shall.anarcat.dyndns.org 4.4-STABLE FreeBSD 4.4-STABLE #0: Fri Nov 16 12:57:38 EST 2001 anarcat@shall.anarcat.dyndns.org:/usr/obj/usr/src/sys/SHALL i386 >Description: There is a new stable version of ecasound. It doesn't compile right of the box again. So there are 2 new patches in the files/ dir. ecasound's kvutils lib shows a bad behavior on FreeBSD wrt handling of temporary directories and that makes ecawave simply fail to work properly (cannot create temp directory /var/tmp/ecawave-[user]). A patch is included in this upgrade. I will contact the authors to try to merge the patches back into the stable tree. >How-To-Repeat: N/a. >Fix: First, apply this patch to the port: diff -ru /usr/ports/audio/ecasound/Makefile ./Makefile --- /usr/ports/audio/ecasound/Makefile Sat Sep 15 00:35:42 2001 +++ ./Makefile Tue Nov 20 11:59:55 2001 @@ -6,8 +6,7 @@ # PORTNAME= ecasound -PORTVERSION= 2.0.2 -PORTREVISION= 1 +PORTVERSION= 2.0.3 CATEGORIES= audio MASTER_SITES= http://ecasound.seul.org/download/ \ ${MASTER_SITE_SOURCEFORGE} @@ -23,7 +22,7 @@ INSTALLS_SHLIB= yes CONFIGURE_ARGS+= --enable-sys-readline -MAKE_ENV+= ${CONFIGURE_ENV} +MAKE_ENV+= ${CONFIGURE_ENV} .if defined(WITH_MPG123) RUN_DEPENDS+= mpg123:${PORTSDIR}/audio/mpg123 @@ -39,22 +38,23 @@ .if defined(WITH_AUDIOFILE) # very crappy hack to detect audiofile properly -CONFIGURE_ENV+= CPPFLAGS="-I${LOCALBASE}/include" \ - LDFLAGS="-L${LOCALBASE}/lib" \ - CFLAGS="-I${LOCALBASE}/include ${CFLAGS}" \ +CONFIGURE_ENV+= CPPFLAGS="-I${LOCALBASE}/include" \ + LDFLAGS="-L${LOCALBASE}/lib" \ + CFLAGS="-I${LOCALBASE}/include ${CFLAGS}" \ CXXFLAGS="-I${LOCALBASE}/include ${CXXFLAGS}" LIB_DEPENDS+= audiofile.0:${PORTSDIR}/audio/libaudiofile .else CONFIGURE_ARGS+= --disable-audiofile .endif -#.if defined(WITH_PYECASOUND) -#USE_PYTHON= yes -#PLIST_SUB+= WITH_PYECASOUND="" -#.else +.if defined(WITH_PYECASOUND) +USE_PYTHON= yes +PLIST_SUB+= WITH_PYECASOUND="" +BROKEN= some stuff still broken in the py port +.else CONFIGURE_ARGS+= --disable-pyecasound PLIST_SUB+= WITH_PYECASOUND="@comment " -#.endif +.endif MAN1= ecasound-iam.1 ecasound.1 ecatools.1 MAN5= ecasoundrc.5 diff -ru /usr/ports/audio/ecasound/distinfo ./distinfo --- /usr/ports/audio/ecasound/distinfo Fri Aug 24 14:36:01 2001 +++ ./distinfo Mon Oct 15 23:56:20 2001 @@ -1 +1 @@ -MD5 (ecasound-2.0.2.tar.gz) = 33e42f52792bfebfe44b06879493631f +MD5 (ecasound-2.0.3.tar.gz) = d5a696c869e3a68905086db3a2697382 Only in .: files diff -ru /usr/ports/audio/ecasound/pkg-comment ./pkg-comment --- /usr/ports/audio/ecasound/pkg-comment Fri Aug 24 14:36:01 2001 +++ ./pkg-comment Tue Nov 20 11:58:37 2001 @@ -1 +1 @@ -Multitrack audio processing software package +Multitrack audio processing software diff -ru /usr/ports/audio/ecasound/pkg-plist ./pkg-plist --- /usr/ports/audio/ecasound/pkg-plist Fri Aug 24 14:36:01 2001 +++ ./pkg-plist Tue Nov 20 03:24:52 2001 @@ -140,6 +140,7 @@ %%PORTDOCS%%share/doc/ecasound/ecatools_manpage.html %%PORTDOCS%%share/doc/ecasound/examples.html %%PORTDOCS%%share/doc/ecasound/index.html +%%PORTDOCS%%share/doc/ecasound/edi-list.txt %%PORTDOCS%%share/doc/ecasound/programmers_guide/eci_doc.html %%PORTDOCS%%share/doc/ecasound/programmers_guide/programmers_guide.html %%PORTDOCS%%share/doc/ecasound/users_guide/users_guide.html What it does: 1- Upgrade 2.0.2 -> 2.0.3 2- fix whitespace nits in the Makefile to make portlint happy 3- shorten pkg-comment 4- add a missing file to plist 5- uncomment python stuff but enabling it marks the port as broken until I figure out how to deal with python stuff in FreeBSD. And it needs these 2 patches to work properly: --- libecasound/audioio-wave.h.orig Mon Nov 19 14:02:42 2001 +++ libecasound/audioio-wave.h Mon Nov 19 14:02:55 2001 @@ -3,7 +3,7 @@ #include <string> #include <iostream> -#include <stdint.h> +/* #include <stdint.h> */ #include <sys/types.h> #include "audioio-types.h" --- kvutils/temporary_file_directory.cpp.orig Thu Mar 22 13:08:50 2001 +++ kvutils/temporary_file_directory.cpp Tue Nov 20 03:42:09 2001 @@ -64,7 +64,7 @@ } } else { -// cerr << "(kvutils) " << "mkdir(" << tdir_rep << ") failed" << endl; + cerr << "(kvutils) " << "mkdir(" << tdir_rep << ") failed" << endl; valid_rep = false; } } @@ -97,32 +97,32 @@ if (statbuf.st_uid != geteuid()) { valid_rep = false; -// cerr << "(kvutils) " << "st_uid doesn't match." << endl; + cerr << "(kvutils) " << "st_uid doesn't match." << endl; } - if (statbuf.st_gid != getegid()) { - valid_rep = false; -// cerr << "(kvutils) " << "st_gid doesn't match." << endl; - } + //if (statbuf.st_gid != getegid()) { + //valid_rep = false; + //cerr << "(kvutils) " << "st_gid doesn't match." << endl; + //} if (!S_ISDIR(statbuf.st_mode)) { valid_rep = false; -// cerr << "(kvutils) " << "st_mode - not a directory." << endl; + cerr << "(kvutils) " << "st_mode - not a directory." << endl; } if (S_ISLNK(statbuf.st_mode)) { valid_rep = false; -// cerr << "(kvutils) " << "st_mode - a symbolic link." << endl; + cerr << "(kvutils) " << "st_mode - a symbolic link." << endl; } if ((statbuf.st_mode & S_IRWXG) > 0) { valid_rep = false; -// cerr << "(kvutils) " << "st_mode - group has access." << endl; + cerr << "(kvutils) " << "st_mode - group has access." << endl; } if ((statbuf.st_mode & S_IRWXO) > 0) { valid_rep = false; -// cerr << "(kvutils) " << "st_mode - others have access." << endl; + cerr << "(kvutils) " << "st_mode - others have access." << endl; } } That second one is a bit long but will help in case of future problems with temporary dir handling. >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011120171133.C20FA20ADB>