From owner-freebsd-current@FreeBSD.ORG Fri May 19 01:36:30 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E708516A424 for ; Fri, 19 May 2006 01:36:30 +0000 (UTC) (envelope-from rosti.bsd@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.173]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3F1E143D45 for ; Fri, 19 May 2006 01:36:29 +0000 (GMT) (envelope-from rosti.bsd@gmail.com) Received: by ug-out-1314.google.com with SMTP id m3so633723uge for ; Thu, 18 May 2006 18:36:29 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer:mime-version:content-type:content-transfer-encoding; b=ZntzIZz2fwSjost+rYlpiwG7DDFWExaT1PJO0cVr8ifxhFWH1K155204IdgmV5VFTJy6F3F8+gInpxB1PGoUoXWnEXwmMaNFP8lTEe+K0v6UIFttMEinAjMA1zOq6b7IWW0EYbQTwDLoo4QBslgmFSxfEPo4l9CvO34eu/fxpQg= Received: by 10.67.96.14 with SMTP id y14mr1031806ugl; Thu, 18 May 2006 18:11:34 -0700 (PDT) Received: from saturn.lan ( [212.143.154.227]) by mx.gmail.com with ESMTP id q1sm1591961uge.2006.05.18.18.11.32; Thu, 18 May 2006 18:11:34 -0700 (PDT) Date: Fri, 19 May 2006 04:10:52 +0300 From: Rostislav Krasny To: David Xu Message-Id: <20060519041052.ab8dbbe9.rosti.bsd@gmail.com> In-Reply-To: <200605190802.08825.davidxu@freebsd.org> References: <20060430142408.fcd60069.rosti.bsd@gmail.com> <44554601.5090105@freebsd.org> <20060519023732.ea4221dd.rosti.bsd@gmail.com> <200605190802.08825.davidxu@freebsd.org> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.17; i386-portbld-freebsd6.1) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: is@rambler-co.ru, cperciva@freebsd.org, freebsd-current@freebsd.org Subject: Re: FreeBSD-SA-06:14.fpu X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 May 2006 01:36:31 -0000 On Fri, 19 May 2006 08:02:08 +0800 David Xu wrote: > On Friday 19 May 2006 07:37, Rostislav Krasny wrote: > > On Sun, 30 Apr 2006 16:19:29 -0700 > > > > Colin Percival wrote: > > > Rostislav Krasny wrote: > > > > Other possible solution is making the fpu_clean_state() optional by > > > > something like following: > > > > > > > > #ifdef BUG_FXSAVE > > > > #define fpu_clean_state() __fpu_clean_state() > > > > #else > > > > #define fpu_clean_state() ; > > > > #endif > > > > > > > > ... and including "options BUG_FXSAVE" to GENERIC. > > > > > > Yes, this is probably the right solution. My priority was to fix the > > > bug; optimizing performance comes second. > > > > Ok. Is this solution going to be done some day? I could try to make a > > patch but I'm not familiar with the build infrastructure internals. > > > > P.S. what is a better option name: "options BUG_FXSAVE" or "options > > AMD_FXSAVE"? > > Patch is welcome, Ok. What should I do before adding the above #ifdef's? Is it enough to change following files only? src/sys/conf/options src/sys/i386/conf/GENERIC src/sys/i386/conf/NOTES src/sys/i386/conf/PAE src/sys/i386/conf/SMP src/sys/amd64/conf/GENERIC src/sys/amd64/conf/NOTES src/sys/amd64/conf/SMP > but I would call it BUG_FXSAVE like Linux's select() > changed timeout value which only added incompatibility rather than > advantage. I don't know about Linux's select() but according to what I've seen on their "7466f9e72dac13452d871a3fb72fc7bd9c93c864" commit they use X86_FEATURE_FXSAVE_LEAK. What do you think about FXSAVE_LEAK instead of BUG_FXSAVE?