From owner-svn-src-head@freebsd.org Sat Jan 2 14:52:44 2021 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 803414D2489; Sat, 2 Jan 2021 14:52:44 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4D7Py34Wwpz4TTj; Sat, 2 Jan 2021 14:52:43 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 102EqX30000413 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 2 Jan 2021 16:52:36 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 102EqX30000413 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 102EqXQf000412; Sat, 2 Jan 2021 16:52:33 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 2 Jan 2021 16:52:33 +0200 From: Konstantin Belousov To: Alexey Dokuchaev Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r365787 - head/sys/fs/tmpfs Message-ID: References: <202009152219.08FMJGMw065722@repo.freebsd.org> <20210101184400.GA77653@FreeBSD.org> <20210102062906.GA98322@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210102062906.GA98322@FreeBSD.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4D7Py34Wwpz4TTj X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (mx1.freebsd.org: 2001:470:d5e7:1::1 is neither permitted nor denied by domain of kostikbel@gmail.com) smtp.mailfrom=kostikbel@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : No valid SPF, No valid DKIM,none]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEMAIL_FROM(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[2001:470:d5e7:1::1:from]; TO_DN_SOME(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; SPAMHAUS_ZRD(0.00)[2001:470:d5e7:1::1:from:127.0.2.255]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; MIME_TRACE(0.00)[0:+]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jan 2021 14:52:44 -0000 On Sat, Jan 02, 2021 at 06:29:06AM +0000, Alexey Dokuchaev wrote: > On Sat, Jan 02, 2021 at 12:02:23AM +0200, Konstantin Belousov wrote: > > On Fri, Jan 01, 2021 at 06:44:00PM +0000, Alexey Dokuchaev wrote: > > > On Tue, Sep 15, 2020 at 10:19:16PM +0000, Konstantin Belousov wrote: > > > > New Revision: 365787 > > > > URL: https://svnweb.freebsd.org/changeset/base/365787 > > > > > > > > Log: > > > > Add tmpfs page cache read support. > > > > > > > > Or it could be explained as lockless (for vnode lock) reads. Reads > > > > are performed from the node tn_obj object. Tmpfs regular vnode object > > > > lifecycle is significantly different from the normal OBJT_VNODE: it is > > > > alive as far as ref_count > 0. > > > > > > This causes panics for me when building ports in the tmpfs-backed tinderbox. > > > Easily reproducible: > > > > > > 1) ./tc tinderbuild ... -b "$@" > > > 2) tail -f .../tmp/make.log4 # on the adjacent console > > > 3) wait until the build job finishes > > > 4) ^C in the "tail" window -> crash > > > > What exactly 'crash' is? > > The usual "Fatal trap 12: page fault while in kernel mode" panic. And everything else ? There is a lot of useful data there (for me at least). > > > Provide literal transcription of the kernel messages and not your > > interpretation of them. > > Sorry, I've just quickly copied function names off the screen since my > debug symbols did not match the running kernel at that moment and I've > thought maybe it's a known bug that was fixed after r368820. I've now > made things in sync so can provide full context (see below). > > > > ... > > > __mtx_lock_sleep() at __mtx_lock_sleep+0xd2/frame 0xfffffe0060636490 > > > tmpfs_free_node() at tmpfs_free_node+0xc7/frame 0xfffffe00606364c0 > > > > What is the source line for tmpfs_free_node() frame? > > /usr/src/crash-dec/sys/fs/tmpfs/tmpfs_subr.c:373 > > (kgdb) list *(tmpfs_free_node+0xc7) > 0xffffffff815246d7 is in tmpfs_free_node (/usr/src/crash-dec/sys/fs/tmpfs/tmpfs_subr.c:374). > 369 { > 370 if (refcount_release_if_not_last(&node->tn_refcount)) > 371 return; > 372 > 373 TMPFS_LOCK(tmp); > 374 TMPFS_NODE_LOCK(node); > 375 if (!tmpfs_free_node_locked(tmp, node, false)) { > 376 TMPFS_NODE_UNLOCK(node); > 377 TMPFS_UNLOCK(tmp); > 378 } > (kgdb) Ok. So two questions: 1. Do you have core dump? If not, can you configure it and obtain the dump? 2. Can you look more closely what you do from the user PoV there, and provide a recipe to reproduce without involving 'tc tinderbiuild', whatever it is ? In particular, I want to see the *node content.